From: Shin Kojima <shin@kojima.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Shin Kojima <shin@kojima.org>,
git@vger.kernel.org, Christopher Wilson <cwilson@cdwilson.us>,
Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH v2] gitweb: apply fallback encoding before highlight
Date: Wed, 4 May 2016 17:34:55 +0900 [thread overview]
Message-ID: <20160504083449.GA46041@skmba.local> (raw)
In-Reply-To: <xmqq7ffbng8p.fsf@gitster.mtv.corp.google.com>
On Tue, May 03, 2016 at 11:33:42AM -0700, Junio C Hamano wrote:
> Shin Kojima <shin@kojima.org> writes:
>
> > Some multi-byte character encodings (such as Shift_JIS and GBK) have
> > characters whose final bytes is an ASCII '\' (0x5c), and they
> > will be displayed as funny-characters even if $fallback_encoding is
> > correct.
>
> Just out of curiosity, do people still use Shift_JIS aka MS-Kanji?
> It feels so last-decade, if not last-century ;-)
Yes, they do. There are still tons of code from 90's lying around.
For migrating our codebase from cp932 (Windows31J/MS-Kanji), I keep
failing to persuade my boss saying it has no incentives to do so.
I can say this patch, to consider $fallback_encoding while
highlighting, is fairly rational. But I also feel this is too much
just for specific outdated character encodings, it is completely
useless for the most part of gitweb users in the world.
I would rather prefer to generate feedback from you all to convince
our management if this patch is not acceptable.
next prev parent reply other threads:[~2016-05-04 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 11:32 [PATCH] gitweb: apply fallback encoding before highlight Shin Kojima
2016-05-02 17:49 ` Junio C Hamano
2016-05-02 18:12 ` Jakub Narębski
2016-05-03 13:00 ` [PATCH v2] " Shin Kojima
2016-05-03 18:33 ` Junio C Hamano
2016-05-04 8:34 ` Shin Kojima [this message]
2016-05-04 19:34 ` Junio C Hamano
2016-05-05 10:22 ` Shin Kojima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504083449.GA46041@skmba.local \
--to=shin@kojima.org \
--cc=cwilson@cdwilson.us \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).