From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: "Elia Pinto" <gitter.spiros@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"Torsten Bögershausen" <tboegi@web.de>,
"Ramsay Jones" <ramsay@ramsayjones.plus.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCHv4 1/2] http.c: implement the GIT_TRACE_CURL environment variable
Date: Thu, 28 Apr 2016 13:44:24 -0400 [thread overview]
Message-ID: <20160428174423.GA32486@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79kYe-WsAJj3xkr9YkHZbHqQ9rhKV80+K0Bx3SZsB85+tHA@mail.gmail.com>
On Thu, Apr 28, 2016 at 10:26:06AM -0700, Stefan Beller wrote:
> > +'GIT_TRACE_CURL'::
> > + Enables a curl full trace dump of all incoming and outgoing data,
> > + including descriptive information, of the git transport protocol.
> > + This is similar to doing curl --trace-ascii on the command line.
> > + This option overrides setting the GIT_CURL_VERBOSE environment
> > + variable.
>
> How does it overwrite the GIT_CURL_VERBOSE variable?
You can't use both, as they are both triggered using the CURLOPT_VERBOSE
option of curl. The main difference is that with GIT_CURL_VERBOSE, we
rely on curl to print the information to stderr. With GIT_CURL_TRACE, we
do the printing ourselves (so we can tweak the output format, send it to
places other than stderr, etc).
> After a quick `grep -r GIT_CURL_VERBOSE`, I notice 2 things:
>
> * apparently GIT_CURL_VERBOSE is used as a boolean,
> so I presume we assume True for GIT_CURL_VERBOSE, but
> extend it?
It's not a boolean. If the variable exists at all, we turn on verbose
output (so I guess you can consider it a boolean, but we do not parse
its contents as boolean; GIT_CURL_VERBOSE=false does not do what you
might think).
> * GIT_CURL_VERBOSE is not documented at all. (It is mentioned in
> the release notes for 2.3.0, not sure if that counts as documentation)
> As you know the area, care to send a documentation patch for
> GIT_CURL_VERBOSE?
I think there is no need for GIT_CURL_VERBOSE once we have
GIT_TRACE_CURL. The latter is more flexible and matches the GIT_TRACE_*
interface we use elsewhere.
So I think we should consider GIT_CURL_VERBOSE deprecated (though I do
not mind keeping it for old-timers since it is literally one line of
code).
-Peff
next prev parent reply other threads:[~2016-04-28 17:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 11:57 [PATCHv4 0/2] Implement the GIT_TRACE_CURL environment variable Elia Pinto
2016-04-28 11:57 ` [PATCHv4 1/2] http.c: implement " Elia Pinto
2016-04-28 14:47 ` Jeff King
2016-04-28 17:35 ` Junio C Hamano
2016-04-28 17:26 ` Stefan Beller
2016-04-28 17:44 ` Jeff King [this message]
2016-04-28 17:48 ` Stefan Beller
2016-04-28 18:05 ` Jeff King
2016-04-28 11:57 ` [PATCHv4 2/2] imap-send.c: introduce the GIT_TRACE_CURL enviroment variable Elia Pinto
2016-04-28 14:55 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428174423.GA32486@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitter.spiros@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).