From: Jeff King <peff@peff.net>
To: Philip Oakley <philipoakley@iee.org>
Cc: Git List <git@vger.kernel.org>
Subject: Re: definition for _attribute() in remote.c
Date: Mon, 25 Apr 2016 17:39:26 -0400 [thread overview]
Message-ID: <20160425213926.GC11227@sigill.intra.peff.net> (raw)
In-Reply-To: <F23050BD4C62408D97A64B1D885007A8@PhilipOakley>
On Mon, Apr 25, 2016 at 10:34:27PM +0100, Philip Oakley wrote:
> It's not the __attribute__ definition (a Gnu C ism), rather its the
> __attribute variant, which has a definition in regex_internal.h, and is used
> in the regex code. It's that one that's used in remote.c that I can't fathom
> (i.e. how it worked in normally)
>
> regex_internal.h#L160-164
> #ifdef __GNUC__
> # define __attribute(arg) __attribute__ (arg)
> #else
> # define __attribute(arg)
> #endif
>
> thus when the compilation get to remote.c#L1662 it fails to find that
> definition.
>
> Should that line use the gnu extension name?
Yeah, sorry, see my followup response. We don't use "__attribute" at
all ourselves. The reference you found is in compat code that we pulled
in (so it does its own thing entirely), and the one in remote.c is just
a typo/think-o that happened to work on gcc, et al.
-Peff
prev parent reply other threads:[~2016-04-25 21:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 21:02 definition for _attribute() in remote.c Philip Oakley
2016-04-25 21:10 ` Jeff King
2016-04-25 21:15 ` [PATCH] remote.c: spell __attribute__ correctly Jeff King
2016-04-25 21:50 ` Philip Oakley
2016-04-25 22:14 ` Ramsay Jones
2016-04-26 13:19 ` Philip Oakley
2016-04-25 21:34 ` definition for _attribute() in remote.c Philip Oakley
2016-04-25 21:39 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425213926.GC11227@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).