From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] t9824: fix broken &&-chain in a subshell
Date: Sun, 24 Apr 2016 18:37:29 +0200 [thread overview]
Message-ID: <20160424183729.Horde.yxK_t3vqDHiCc6kvoXJqwst@webmail.informatik.kit.edu> (raw)
In-Reply-To: <78046710-31FD-43D8-820E-95D56564C3F5@gmail.com>
Quoting Lars Schneider <larsxschneider@gmail.com>:
> On 24 Apr 2016, at 13:50, SZEDER Gábor <szeder@ira.uka.de> wrote:
>
>> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
>> ---
>>
>> As far as I can tell after eyeballing the test script, this was the
>> only case where the &&-chain was broken.
>>
>> t/t9824-git-p4-git-lfs.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh
>> index 0b664a377c45..64f8d18216d4 100755
>> --- a/t/t9824-git-p4-git-lfs.sh
>> +++ b/t/t9824-git-p4-git-lfs.sh
>> @@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and
>> store files in LFS based on compr
>> # We only import HEAD here ("@all" is missing!)
>> git p4 clone --destination="$git" //depot &&
>>
>> - test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ"
>> + test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" &&
> Thanks! I believe I remember some script/flag to detect broken &&-chains.
> Do I imagine that or can anyone point me to it?
It was introduced in bb79af9d0970 (t/test-lib: introduce --chain-lint
option, 2015-03-20) and is enabled by default. Unfortunately, it
can't "see" inside subshells, that's why it couldn't detect this case.
>> test_file_count_in_dir ".git/lfs/objects" 1 &&
>>
>> cat >expect <<-\EOF &&
>> --
>> 2.8.1.99.g5d5236f
>>
next prev parent reply other threads:[~2016-04-24 16:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 20:08 [PATCH v1 0/2] git-p4: fix Git LFS pointer parsing larsxschneider
2016-04-19 20:08 ` [PATCH v1 1/2] travis-ci: update Git-LFS and P4 to the latest version larsxschneider
2016-04-19 20:08 ` [PATCH v1 2/2] git-p4: fix Git LFS pointer parsing larsxschneider
2016-04-19 20:30 ` Junio C Hamano
2016-04-19 20:54 ` Lars Schneider
2016-04-19 21:04 ` Junio C Hamano
2016-04-20 8:32 ` Sebastian Schuberth
2016-04-20 15:30 ` Junio C Hamano
2016-04-20 15:40 ` Sebastian Schuberth
2016-04-24 11:50 ` [PATCH] t9824: fix broken &&-chain in a subshell SZEDER Gábor
2016-04-24 16:29 ` Lars Schneider
2016-04-24 16:37 ` SZEDER Gábor [this message]
2016-04-24 16:50 ` Lars Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160424183729.Horde.yxK_t3vqDHiCc6kvoXJqwst@webmail.informatik.kit.edu \
--to=szeder@ira.uka.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).