git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
	Duy Nguyen <pclouds@gmail.com>,
	Stefan Beller <sbeller@google.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: Parallel checkout (Was Re: 0 bot for Git)
Date: Fri, 15 Apr 2016 13:38:33 -0400	[thread overview]
Message-ID: <20160415173833.GA20014@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqwpnybwxw.fsf@gitster.mtv.corp.google.com>

On Fri, Apr 15, 2016 at 10:31:39AM -0700, Junio C Hamano wrote:

> Last time I checked, I think the accesses to attributes from the
> convert.c thing was one of the things that are cumbersome to make
> safe in multi-threaded world.

Multi-threaded grep has the same problem. I think we started with a big
lock on the attribute access. That works OK, as long as you hold the
lock only for the lookup and not the actual filtering. We later moved to
pre-loading the attributes in 9dd5245c104, because looking up attributes
in order is much more efficient (because locality of paths lets us reuse
work from the previous request).

So I'm guessing the major work here will be to split the "look up smudge
attributes" step from "do the smudge".

-Peff

  reply	other threads:[~2016-04-15 17:38 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAGZ79kYWGFN1W0_y72-V6M3n4WLgtLPzs22bWgs1ObCCDt5BfQ@mail.gmail.com>
2016-04-12  4:29 ` 0 bot for Git Stefan Beller
2016-04-12  6:41   ` Greg KH
2016-04-12  7:23   ` Matthieu Moy
2016-04-12 14:52     ` Stefan Beller
2016-04-12 15:15       ` Philip Li
2016-04-12 20:29       ` Matthieu Moy
2016-04-12 20:49         ` Junio C Hamano
2016-04-13  5:43           ` Matthieu Moy
2016-04-13 12:16             ` Lars Schneider
2016-04-13 12:30               ` Matthieu Moy
2016-04-13 16:14                 ` Lars Schneider
2016-04-13 16:15                 ` Junio C Hamano
2016-04-13  6:11           ` Lars Schneider
2016-04-13 16:27             ` Junio C Hamano
2016-04-13 17:09               ` Lars Schneider
2016-04-13 17:29                 ` Stefan Beller
2016-04-13 17:43                   ` Greg KH
2016-04-16 15:51                   ` Lars Schneider
2016-04-16 18:02                     ` Junio C Hamano
2016-04-22  8:19                       ` Lars Schneider
2016-04-22 17:30                         ` Junio C Hamano
2016-04-24  7:15                           ` Johannes Schindelin
2016-04-24 12:19                             ` SZEDER Gábor
2016-04-24 13:05                               ` Johannes Schindelin
     [not found]                             ` <CAE5ih7-fyuEvSDzmHVfXta3hd_7ZRp1+_VtytDM+u0372Kyidg@mail.gmail.com>
     [not found]                               ` <CAE5ih7_fabo7DyZyHoxdp1Y4ygby2qwKA8E1N6MuGzHa60Wf4w@mail.gmail.com>
     [not found]                                 ` <CAE5ih7-DzFe_3=kyan=E17zCo-iNdNdH7DE5ZwYVHmFvUBkDkA@mail.gmail.com>
     [not found]                                   ` <CAE5ih7-d9ow0dF6wfWCkmx+HAQOzVBONGCC_U4-2bkDUZGPecQ@mail.gmail.com>
     [not found]                                     ` <CAE5ih7_OEAWjYm9LwMAwBCtnvG+KgGo1aFuT9CyQjeN6nFmC5w@mail.gmail.com>
     [not found]                                       ` <CAE5ih7-z8K5Z7HuBa=pF53b6obU60ZCxrEkTLWbaSMsg0G1Ctg@mail.gmail.com>
     [not found]                                         ` <CAE5ih78arC2V76XR7yUoXk77c0d_z3Hzupw6MA1+saS3faXjTw@mail.gmail.com>
2016-04-24 13:05                                           ` Johannes Schindelin
     [not found]                                           ` <1C553D20-26D9-4BF2-B77E-DEAEDDE869E2@gmail.com>
2016-04-25 14:07                                             ` Johannes Schindelin
2016-04-13 17:47                 ` Junio C Hamano
2016-04-13 13:44           ` Fengguang Wu
2016-04-12  9:42   ` Duy Nguyen
2016-04-12 14:59     ` Stefan Beller
2016-04-14 22:04       ` Christian Couder
2016-04-15  9:51         ` Parallel checkout (Was Re: 0 bot for Git) Duy Nguyen
2016-04-15 11:18           ` Christian Couder
2016-04-15 11:32             ` Duy Nguyen
2016-04-15 16:52             ` Jeff King
2016-04-15 17:31               ` Junio C Hamano
2016-04-15 17:38                 ` Jeff King [this message]
2016-04-16  5:17               ` Michael Haggerty
2016-04-15 15:08           ` Stefan Beller
2016-04-16  0:16             ` Duy Nguyen
2016-04-26 11:35           ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160415173833.GA20014@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mhagger@alum.mit.edu \
    --cc=pclouds@gmail.com \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).