From: Marios Titas <redneb@gmx.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] ident: make the useConfigOnly error messages more informative
Date: Thu, 31 Mar 2016 02:25:52 +0300 [thread overview]
Message-ID: <20160330232552.GA31861@zeno> (raw)
In-Reply-To: <xmqqlh4zr492.fsf@gitster.mtv.corp.google.com>
On Wed, Mar 30, 2016 at 03:27:05PM -0700, Junio C Hamano wrote:
>Marios Titas <redneb@gmx.com> writes:
>
>> - && !(ident_config_given & IDENT_NAME_GIVEN))
>> - die("user.useConfigOnly set but no name given");
>> + && !(ident_config_given & IDENT_NAME_GIVEN)) {
>> + fputs(env_hint, stderr);
>> + die("no name was given and auto-detection is disabled
>
>Hmph. I do not think that this is making the message "more
>informative".
>
>When a user hits this error, the old message allowed the user to
>easily see how to toggle the "disable auto-detection" bit off to let
>the code continue by telling the name of the configuration, but the
>updated message hides that name, making it harder for the user to
>disable the disabling of auto-detection.
>
>I can buy the argument that this change helps the user by making the
>message "less" informative, though. By discouraging the users from
>toggling the user.useConfigOnly bit off, it indirectly makes the
>other option to work around this error condition, i.e. giving a name
>more explicitly, more appetizing.
Yeah, maybe informative is not the right word. What I meant is that it
directs the user to do the "git config user.name" thing, which is likely
the most appropriate course of action in this situation. In any event, I
think printing the env_hint message would be really helpful in this
case.
next prev parent reply other threads:[~2016-03-30 23:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 19:29 [PATCH 1/2] ident: check for useConfigOnly before auto-detection of name/email Marios Titas
2016-03-30 19:29 ` [PATCH 2/2] ident: make the useConfigOnly error messages more informative Marios Titas
2016-03-30 22:27 ` Junio C Hamano
2016-03-30 23:25 ` Marios Titas [this message]
2016-04-01 22:04 ` Junio C Hamano
2016-04-12 23:19 ` Junio C Hamano
2016-03-31 14:40 ` [PATCH 1/2] ident: check for useConfigOnly before auto-detection of name/email Jeff King
2016-03-31 15:01 ` Marios Titas
2016-03-31 16:31 ` Jeff King
2016-04-01 22:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330232552.GA31861@zeno \
--to=redneb@gmx.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).