From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH 4/4] pretty-print: add --pretty=noexpand Date: Fri, 18 Mar 2016 01:55:00 -0400 Message-ID: <20160318055500.GA27875@sigill.intra.peff.net> References: <20160318050807.GC22327@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Junio C Hamano , Git Mailing List To: Linus Torvalds X-From: git-owner@vger.kernel.org Fri Mar 18 07:07:20 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1agnZ9-0003m2-Jx for gcvg-git-2@plane.gmane.org; Fri, 18 Mar 2016 07:07:20 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754014AbcCRFzF (ORCPT ); Fri, 18 Mar 2016 01:55:05 -0400 Received: from cloud.peff.net ([50.56.180.127]:33905 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755329AbcCRFzD (ORCPT ); Fri, 18 Mar 2016 01:55:03 -0400 Received: (qmail 17129 invoked by uid 102); 18 Mar 2016 05:55:03 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Fri, 18 Mar 2016 01:55:03 -0400 Received: (qmail 9012 invoked by uid 107); 18 Mar 2016 05:55:20 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Fri, 18 Mar 2016 01:55:20 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 18 Mar 2016 01:55:00 -0400 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Mar 17, 2016 at 10:36:16PM -0700, Linus Torvalds wrote: > On Thu, Mar 17, 2016 at 10:08 PM, Jeff King wrote: > > > > Hmm. Isn't "expand tabs" orthogonal to the rest of the pretty format? > > That is, couldn't one want "--pretty=fuller, but with tabs expanded"? > > Yeah, you are right, one easily could. And in fact I end up doing > "fuller" myself occasionally, because I check peoples commit > timestamps (some people have a nasty habit of rebasing when they > shouldn't). > > So it's not just the medium format that would want detab by default, > it's "full" and "fuller" too (but probably not "raw": that indents the > message too, but the only real reason to use "raw" is for scripting). > > So it would probably be better to make it a separate flag, and not tie > it to a particular log format (and just make the log format set the > default). Yeah, I agree with all of that. I didn't want to force anybody to have to think too hard about corner cases they don't care about (again, as long as we don't paint ourselves into a corner) but I tend to think that it makes sense to apply it consistently to all of the stock human-readable formats (short, medium, full, fuller), but not to "raw" or "email", and probably not to user-formats. -Peff