From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: gitster@pobox.com, git@vger.kernel.org, jrnieder@gmail.com,
Jens.Lehmann@web.de
Subject: Re: [PATCHv13 5/7] git submodule update: have a dedicated helper for cloning
Date: Fri, 19 Feb 2016 07:03:11 -0500 [thread overview]
Message-ID: <20160219120310.GB10204@sigill.intra.peff.net> (raw)
In-Reply-To: <1455838398-12379-6-git-send-email-sbeller@google.com>
On Thu, Feb 18, 2016 at 03:33:16PM -0800, Stefan Beller wrote:
> + if (needs_cloning) {
> + cp->git_cmd = 1;
> + cp->no_stdin = 1;
> + cp->stdout_to_stderr = 1;
> + cp->err = -1;
> + argv_array_push(&cp->args, "submodule--helper");
> + argv_array_push(&cp->args, "clone");
> + if (pp->quiet)
> + argv_array_push(&cp->args, "--quiet");
> +
> + if (pp->prefix)
> + argv_array_pushl(&cp->args, "--prefix", pp->prefix, NULL);
> +
> + argv_array_pushl(&cp->args, "--path", sub->path, NULL);
> + argv_array_pushl(&cp->args, "--name", sub->name, NULL);
> + argv_array_pushl(&cp->args, "--url", strdup(url), NULL);
No need to strdup() here; argv_array handles its own memory, so this
just leaks (and if we were keeping it, it should be xstrdup(), of
course).
-Peff
next prev parent reply other threads:[~2016-02-19 12:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 23:33 [PATCHv13 0/7] Expose submodule parallelism to the user Stefan Beller
2016-02-18 23:33 ` [PATCHv13 1/7] submodule-config: keep update strategy around Stefan Beller
2016-02-18 23:33 ` [PATCHv13 2/7] submodule-config: drop check against NULL Stefan Beller
2016-02-18 23:33 ` [PATCHv13 3/7] fetching submodules: respect `submodule.fetchJobs` config option Stefan Beller
2016-02-18 23:33 ` [PATCHv13 4/7] submodule update: direct error message to stderr Stefan Beller
2016-02-18 23:33 ` [PATCHv13 5/7] git submodule update: have a dedicated helper for cloning Stefan Beller
2016-02-19 12:03 ` Jeff King [this message]
2016-02-19 16:47 ` Stefan Beller
2016-02-19 17:20 ` Eric Sunshine
2016-02-19 19:08 ` Jeff King
2016-02-19 19:10 ` Stefan Beller
2016-02-18 23:33 ` [PATCHv13 6/7] submodule update: expose parallelism to the user Stefan Beller
2016-02-18 23:33 ` [PATCHv13 7/7] clone: allow an explicit argument for parallel submodule clones Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160219120310.GB10204@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).