From: Jeff King <peff@peff.net>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: larsxschneider@gmail.com, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2] config: add '--sources' option to print the source of a config value
Date: Wed, 10 Feb 2016 10:40:06 -0500 [thread overview]
Message-ID: <20160210154006.GA19867@sigill.intra.peff.net> (raw)
In-Reply-To: <CAHGBnuMMN_xEVDJ_dqWgL6QCGK08hy=ggg=6PzkSCinHr=QeFg@mail.gmail.com>
On Wed, Feb 10, 2016 at 04:33:11PM +0100, Sebastian Schuberth wrote:
> > where two of the prefixes have nothing in the second slot. I expected
> > something more like:
> >
> > file:<filename>\t</value...>
> > blob:<blob>\t<value...>
> > stdin\t<value...>
> > cmd\t<value...>
> >
> > with a single delimited slot for the source, which can then be broken
> > down further if desired. I can't think of any reason to prefer one over
> > the other rather than personal preference, though. They can both be
> > parsed unambiguously.
>
> I also would have expected sopme like the latter, except that I'd also
> expect a colon after "stdin" and "cmd" (or "cmdline", as said above).
> I.e. the colon should be part of the prefix to mark it as such.
Yeah, I waffled on that. Having a colon means you can definitely parse
to the first ":" without looking at what the prefix is. But if you don't
know what the prefix is, I don't know what good that does you. IOW, I'd
expect it to be parsed like:
if (/^file:(.*)/) {
# source is file $1
} elsif (/^blob:(.*)/) {
# source is blob $1
} elsif (/^stdin/) {
# source is stdin
} elsif (/^cmdline/) {
# source is cmdline
} else {
die "eh? I don't know about $_ at all!"
}
That's perl, but I think most languages make prefix-parsing like that
easy. I dunno. I doubt it matters all that much, and we are deep into
personal preference. There's already plenty to bikeshed on the option
name :)
-Peff
next prev parent reply other threads:[~2016-02-10 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 10:13 [PATCH v2] config: add '--sources' option to print the source of a config value larsxschneider
2016-02-10 12:47 ` Ramsay Jones
2016-02-10 15:28 ` Sebastian Schuberth
2016-02-10 16:03 ` Ramsay Jones
2016-02-10 12:54 ` Jeff King
2016-02-10 15:33 ` Sebastian Schuberth
2016-02-10 15:40 ` Jeff King [this message]
2016-02-10 15:57 ` Sebastian Schuberth
2016-02-10 16:24 ` Jeff King
2016-02-10 19:03 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210154006.GA19867@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).