From: Jeff King <peff@peff.net>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: "git tag --contains <id>" is too chatty, if <id> is invalid
Date: Mon, 18 Jan 2016 16:54:33 -0500 [thread overview]
Message-ID: <20160118215433.GB24136@sigill.intra.peff.net> (raw)
In-Reply-To: <569D580F.4070302@gmx.de>
On Mon, Jan 18, 2016 at 10:24:31PM +0100, Toralf Förster wrote:
> very first line is "error: malformed object name <id>" which tells all, or ?
Yeah, I agree that showing the "-h" help is a bit much.
This is a side effect of looking up in the commit in the parse-options
callback. It has to signal an error to the option parser, and then the
option parser always shows the help on an error.
I think we'd need to do one of:
1. call die() in the option-parsing callback (this is probably a bad
precedent, as the callbacks might be reused from a place that wants
to behave differently)
2. have the callback just store the argument string, and then resolve
the commit later (and die or whatever if it doesn't exist). This
pushes more work onto the caller, but in this case it's all done by
the ref-filter code, so it could presumably happen during another
part of the ref-filter setup.
3. teach parse-options to accept some specific non-zero return code
that means "return an error, but don't show the usage"
I think any one of those would be a good project for somebody looking to
get their feet wet in working on git. I think (2) is the cleanest.
-Peff
next prev parent reply other threads:[~2016-01-18 21:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 21:24 "git tag --contains <id>" is too chatty, if <id> is invalid Toralf Förster
2016-01-18 21:54 ` Jeff King [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-03-19 16:49 Chirayu Desai
2016-03-19 17:04 ` Pranit Bauva
2016-03-19 17:51 ` Chirayu Desai
2016-03-19 17:57 ` Jeff King
2016-03-19 18:08 ` Chirayu Desai
2016-03-19 18:12 ` Jeff King
2016-03-20 6:49 ` Chirayu Desai
2016-03-23 22:41 ` Jeff King
2016-03-24 17:22 ` Chirayu Desai
2016-03-20 22:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118215433.GB24136@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).