From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH 1/2] prepare_packed_git(): refactor garbage reporting in pack directory Date: Wed, 13 Jan 2016 15:23:29 -0500 Message-ID: <20160113202329.GA7678@sigill.intra.peff.net> References: <20151104200249.GC16101@sigill.intra.peff.net> <20151230073759.GA785@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Junio C Hamano , Git List , Eric Sunshine To: Doug Kelly X-From: git-owner@vger.kernel.org Wed Jan 13 21:23:37 2016 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aJRxA-0003sq-QH for gcvg-git-2@plane.gmane.org; Wed, 13 Jan 2016 21:23:37 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933363AbcAMUXc (ORCPT ); Wed, 13 Jan 2016 15:23:32 -0500 Received: from cloud.peff.net ([50.56.180.127]:53257 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S933310AbcAMUXb (ORCPT ); Wed, 13 Jan 2016 15:23:31 -0500 Received: (qmail 12632 invoked by uid 102); 13 Jan 2016 20:23:31 -0000 Received: from Unknown (HELO peff.net) (10.0.1.1) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Wed, 13 Jan 2016 15:23:31 -0500 Received: (qmail 32639 invoked by uid 107); 13 Jan 2016 20:23:49 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Wed, 13 Jan 2016 15:23:49 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 13 Jan 2016 15:23:29 -0500 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, Jan 13, 2016 at 02:19:05PM -0600, Doug Kelly wrote: > However, back to the point: should the wait value be hard coded? Configurable > as a new option? What should our default wait be? I'd think it would make sense to match the expiration time we feed to prune. That's overly conservative, but I think that's OK (and the user can tweak it down). -Peff