From: Richard Ipsum <richard.ipsum@codethink.co.uk>
To: git@vger.kernel.org
Cc: Dave Borowitz <dborowitz@google.com>,
Stefan Beller <sbeller@google.com>,
Edwin Kempin <ekempin@google.com>
Subject: Working towards a common review format for git
Date: Fri, 8 Jan 2016 14:08:31 +0000 [thread overview]
Message-ID: <20160108140831.GA10200@salo> (raw)
Hi,
In a prior email I mentioned in passing a library I've been working
on to try to reach a common format for storing review content in git:
perl-notedb.[1]
I'm making reasonable progress with this but my work has uncovered
necessary (and trivial) modifications to Notedb, the first[2] is a
trivial modification to ensure the 'Status' trailer gets written
to the commit when a change's status changes. The second[3] is an RFC
where I suggest adding a 'Commit' trailer so that it is always
possible to reference the commit under review by its sha.
With these patches applied to gerrit it's possible for perl-notedb to parse
all meta content from notedb and map it to the actual git content
under review. However, my concern at present is that I'm already
operating under a fork of notedb which defeats the objective of
collaborating to produce a standard format, let's try to avoid[4]
If the gerrit folks could let me know what I need to do to get
these modifications merged, or else what we need to do to achieve
equivalent functionality I'd really appreciate it.
Thanks again,
Richard Ipsum
[1]: https://bitbucket.org/richardipsum/perl-notedb
[2]: https://gerrit-review.googlesource.com/#/c/73436/
[3]: https://gerrit-review.googlesource.com/#/c/73602/
[4]: https://xkcd.com/927/
next reply other threads:[~2016-01-08 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 14:08 Richard Ipsum [this message]
2016-01-08 14:24 ` Working towards a common review format for git Dave Borowitz
2016-01-08 14:53 ` Dave Borowitz
2016-01-08 19:23 ` Richard Ipsum
2016-01-08 19:26 ` Dave Borowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108140831.GA10200@salo \
--to=richard.ipsum@codethink.co.uk \
--cc=dborowitz@google.com \
--cc=ekempin@google.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).