From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] credential-store: don't pass strerror to die_errno()
Date: Wed, 16 Dec 2015 13:20:16 -0500 [thread overview]
Message-ID: <20151216182016.GA31510@sigill.intra.peff.net> (raw)
In-Reply-To: <1450264975-9760-1-git-send-email-szeder@ira.uka.de>
On Wed, Dec 16, 2015 at 12:22:55PM +0100, SZEDER Gábor wrote:
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
> ---
>
> v2 fixed this, but it fell on the floor, I suppose because of the
> maintainer switch. Anyway, I should have noticed it while the patch
> was still cooking, sorry.
Oops. I do remember seeing Eric point out the problem and I think I was
planning to fix it up before merging. But I didn't make a note in
whats-cooking, so Junio had no idea of my plan.
> credential-store.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Patch is obviously correct. Thanks.
-Peff
prev parent reply other threads:[~2015-12-16 18:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 11:40 [PATCH] Make error message after failing commit_lock_file() less confusing SZEDER Gábor
2015-12-01 23:17 ` Jeff King
2015-12-02 2:19 ` Junio C Hamano
2015-12-02 4:28 ` Eric Sunshine
2015-12-03 10:30 ` SZEDER Gábor
2015-12-03 10:31 ` [PATCH v2] " SZEDER Gábor
2015-12-16 11:22 ` [PATCH] credential-store: don't pass strerror to die_errno() SZEDER Gábor
2015-12-16 18:20 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151216182016.GA31510@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).