From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
Stefan Beller <sbeller@google.com>,
Anthony Sottile <asottile@umich.edu>
Subject: Re: [PATCH 3/2] git.c: make sure we do not leak GIT_* to alias scripts
Date: Tue, 8 Dec 2015 12:20:10 -0500 [thread overview]
Message-ID: <20151208172010.GA12886@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8BHT2+_i4SoG6xv40wGX_gxwZFk=3WYOH196ZiHA7raWQ@mail.gmail.com>
On Tue, Dec 08, 2015 at 05:55:20PM +0100, Duy Nguyen wrote:
> On Mon, Dec 7, 2015 at 7:54 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> >
> >> Let's hope there will be no third report about this commit..
> >
> > Hmm, why does this additional test fail only under prove but pass
> > without it?
>
> It passes with prove for me. Some mysterious variable leaks through somehow?
It fails for me when run via "make" (with prove or without) but not as
"./t0001-init.sh". Looks like extra variables from my config.mak leak
through:
$ make t0001-init.sh GIT_TEST_OPTS="-v -i"
[...]
--- expected 2015-12-08 17:18:06.304699181 +0000
+++ actual 2015-12-08 17:18:06.312699180 +0000
@@ -9,5 +9,9 @@
GIT_MERGE_VERBOSITY
GIT_PREFIX
GIT_TEMPLATE_DIR
+GIT_TEST_GIT_DAEMON
+GIT_TEST_HTTPD
+GIT_TEST_OPTS
GIT_TEXTDOMAINDIR
GIT_TRACE_BARE
+MAKEFLAGS
not ok 6 - No extra GIT_* on alias scripts
Any GIT_TEST_* is allowed through by test-lib.sh.
For the MAKEFLAGS one, I suspect it's hitting
MAKEFLAGS=GIT_TEST_OPTS=...
You should probably anchor your regex. :)
-Peff
next prev parent reply other threads:[~2015-12-08 17:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+dzEB=2LJXiLSTqyLw8AeHNwdQicwvEiMg=hVEX0-_s1bySpA@mail.gmail.com>
2015-11-24 2:22 ` Fwd: Git clone fails during pre-commit hook due to GIT_WORK_TREE=. (regression 2.5 -> 2.6) Anthony Sottile
2015-11-24 17:57 ` Stefan Beller
2015-11-25 20:13 ` Duy Nguyen
2015-11-30 19:01 ` Duy Nguyen
2015-11-30 20:16 ` Junio C Hamano
2015-12-01 17:59 ` Duy Nguyen
2015-12-02 17:09 ` Junio C Hamano
2015-12-03 18:17 ` [PATCH 1/2] git.c: make it clear save_env() is for alias handling only Nguyễn Thái Ngọc Duy
2015-12-03 18:17 ` [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when Nguyễn Thái Ngọc Duy
2015-12-04 20:35 ` Junio C Hamano
2015-12-05 5:48 ` Duy Nguyen
2015-12-05 15:32 ` [PATCH 3/2] git.c: make sure we do not leak GIT_* to alias scripts Nguyễn Thái Ngọc Duy
2015-12-07 18:54 ` Junio C Hamano
2015-12-08 16:55 ` Duy Nguyen
2015-12-08 17:20 ` Jeff King [this message]
2015-12-08 23:55 ` Junio C Hamano
2015-12-05 19:12 ` [PATCH 2/2] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when Duy Nguyen
2015-12-07 18:33 ` Junio C Hamano
2015-12-20 7:50 ` [PATCH v2 0/3] nd/clear-gitenv-upon-use-of-alias Nguyễn Thái Ngọc Duy
2015-12-20 7:50 ` [PATCH v2 1/3] git.c: make it clear save_env() is for alias handling only Nguyễn Thái Ngọc Duy
2015-12-20 7:50 ` [PATCH v2 2/3] setup.c: re-fix d95138e (setup: set env $GIT_WORK_TREE when Nguyễn Thái Ngọc Duy
2015-12-20 7:50 ` [PATCH v2 3/3] git.c: make sure we do not leak GIT_* to alias scripts Nguyễn Thái Ngọc Duy
2015-12-21 21:18 ` [PATCH v2 0/3] nd/clear-gitenv-upon-use-of-alias Junio C Hamano
2015-12-22 10:57 ` Duy Nguyen
2015-12-22 11:53 ` Duy Nguyen
2015-12-22 18:13 ` Junio C Hamano
2015-12-23 9:37 ` Jeff King
2015-12-23 10:20 ` Duy Nguyen
2015-12-23 16:17 ` Eric Sunshine
2015-12-23 20:37 ` Johannes Sixt
2015-12-23 21:31 ` Jeff King
2015-12-24 9:35 ` Duy Nguyen
2015-12-29 8:12 ` Jeff King
2015-12-29 21:34 ` Junio C Hamano
2015-12-21 10:22 ` [PATCH] Revert "setup: set env $GIT_WORK_TREE when work tree is set, like $GIT_DIR" Nguyễn Thái Ngọc Duy
2015-12-21 17:28 ` Junio C Hamano
2015-12-21 18:31 ` Junio C Hamano
2015-12-22 1:06 ` Duy Nguyen
2015-12-22 21:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208172010.GA12886@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=asottile@umich.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).