From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johan Herland <johan@herland.net>
Subject: Re: [PATCH] notes: Allow treeish expressions as notes ref
Date: Thu, 8 Oct 2015 11:50:18 +0900 [thread overview]
Message-ID: <20151008025018.GA29722@glandium.org> (raw)
In-Reply-To: <xmqqzj30yq03.fsf@gitster.dls.corp.google.com>
On Mon, Jul 13, 2015 at 09:35:40AM -0700, Junio C Hamano wrote:
> What is interesting is to think what should happen when amlog@{1}
> is given. The version with your patch gives the same output as we
> saw earlier, because amlog@{1} tree exists, but does not know about
> your patch (yet), so does not add "Notes" section, which makes sense
> by itself.
>
> But we cannot tell if amlog@{1} was somehow malformed or it was OK
> and there was no notes on the commit.
>
> We probably should do a few more things:
>
> - Make sure that we show "there is no such tree-ish, no way to look
> up any note to any commit from there" and "I understood the tree
> you gave me, but there is no note for that commit" differently.
After refreshing the patch against current "next", it appears that
there is such a distinction:
$ ./git-log --notes=fdsfgsfdg HEAD^! --pretty=short
warning: notes ref refs/notes/fdsfgsfdg is invalid
commit e5b68b2e879608d881c2e3600ce84962fcdefc88
Author: Mike Hommey <mh@glandium.org>
notes: allow treeish expressions as notes ref
$ ./git-log --notes=foo HEAD^! --pretty=short
commit e5b68b2e879608d881c2e3600ce84962fcdefc88
Author: Mike Hommey <mh@glandium.org>
notes: allow treeish expressions as notes ref
(I do have a refs/notes/foo ref)
> - Decide if we want to "fail" the operation when the notes tree
> given by the user is not even a tree-ish or just "warn" and keep
> going. And do so consistently.
Currently, it warns and doesn't fail.
Cheers,
Mike
next prev parent reply other threads:[~2015-10-08 2:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 1:15 [PATCH] notes: Use get_sha1_committish instead of read_ref in init_notes() Mike Hommey
2015-06-17 3:17 ` Junio C Hamano
2015-06-17 9:40 ` Mike Hommey
2015-06-17 15:18 ` Junio C Hamano
2015-06-17 16:35 ` Johan Herland
2015-07-08 10:21 ` [PATCH v2 - RFH] notes: Allow committish expressions as notes ref Mike Hommey
2015-07-09 2:48 ` [PATCH v3] " Mike Hommey
2015-07-10 1:03 ` Johan Herland
2015-07-10 1:28 ` [PATCH v4] notes: Allow treeish " Mike Hommey
2015-07-10 7:16 ` Johan Herland
2015-07-10 7:22 ` Mike Hommey
2015-07-10 8:39 ` [PATCH] " Mike Hommey
2015-07-13 16:35 ` Junio C Hamano
2015-07-13 20:53 ` Mike Hommey
2015-07-13 21:15 ` Junio C Hamano
2015-10-08 2:50 ` Mike Hommey [this message]
2015-10-08 2:54 ` [PATCH v6] notes: allow " Mike Hommey
2015-10-08 19:03 ` [PATCH] notes: Allow " Junio C Hamano
2015-07-13 21:19 ` Junio C Hamano
2015-06-17 3:22 ` [PATCH] notes: Use get_sha1_committish instead of read_ref in init_notes() Jeff King
2015-06-17 9:02 ` Mike Hommey
2015-06-17 16:35 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008025018.GA29722@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).