From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmail.com>,
Jens Lehmann <Jens.Lehmann@web.de>,
Vitali Lovich <vlovich@gmail.com>
Subject: Re: [PATCH 2/2] fetch: fetch submodules in parallel
Date: Mon, 14 Sep 2015 13:17:36 -0400 [thread overview]
Message-ID: <20150914171736.GA1548@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79kaBvVWT1OPMxUAU9N2oaC5TT5wwWew5jS0k_o5J10sKfA@mail.gmail.com>
On Mon, Sep 14, 2015 at 09:46:58AM -0700, Stefan Beller wrote:
> I tried implementing a buffering solution for both stdout and stderr,
> but that doesn't really workout well if you consider interleaved output
> on the pipes as we cannot accurately replay that later on. To do that
> we would need to store the timing information of the channels, at least
> the relative order of it like:
>
> (stdout, First comes text to stdout),
> (stderr, interrupted by text in stderr)
> (stdout, but stdout doesn't bother, blasting more text)
> (stderr, continues to interrupt)
>
> obtaining the information is inherently racy, as all we can do is
> polling/reading from both stdout/err as fast as possible but without
> proper synchronization mechanisms we cannot be sure.
I don't think you need exact timing information. This is no different
than running the commands themselves, with stdout and stderr writing to
a pty that your terminal emulator will then read() from. If the program
produces intermingled stdout/stderr that clogs up the terminal, that is
its problem.
The only difference is that we're going to save it and later replay it
all very quickly. So I think it would be sufficient just to retain the
original order.
> I will add documentation explaining why the async output case
> will only deal with one channel. I chose stderr as that's already
> available and needed in this use case.
I suspect you could just set child->stdout_to_stderr in this case, and
then you get your ordering for free. But probably in the general case
people would want to run inspection commands that produce a useful
stdout.
To handle multiple channels, I think you could just do a linked list of
buffers rather than a single strbuf. Like:
struct io_chunk {
int channel;
char *buf;
size_t len;
struct io_chunk *next;
};
and just keep appending chunks to the list (and to dump them, just walk
the list, writing each to the appropriate channel descriptor).
-Peff
next prev parent reply other threads:[~2015-09-14 17:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 23:09 [RFC PATCHv1 0/2] Parallel git submodule fetching Stefan Beller
2015-09-11 23:09 ` [PATCH 1/2] Sending "Fetching submodule <foo>" output to stderr Stefan Beller
2015-09-11 23:09 ` [PATCH 2/2] fetch: fetch submodules in parallel Stefan Beller
2015-09-12 19:11 ` Junio C Hamano
2015-09-14 16:46 ` Stefan Beller
2015-09-14 17:17 ` Jeff King [this message]
2015-09-14 17:47 ` Stefan Beller
2015-09-14 17:55 ` Jonathan Nieder
2015-09-14 18:07 ` Jeff King
2015-09-14 21:50 ` [PATCHv2] " Stefan Beller
2015-09-14 21:50 ` [PATCHv2] fetch: " Stefan Beller
2015-09-14 22:06 ` [PATCHv2] " Junio C Hamano
2015-09-14 17:56 ` [PATCH 2/2] fetch: " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914171736.GA1548@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmail.com \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
--cc=vlovich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).