On Sat, Aug 08, 2015 at 04:47:46PM -0400, Mark Levedahl wrote: > On 08/07/2015 04:30 PM, Adam Dinwoodie wrote: > >When generating build options for Cygwin, enable > >OBJECT_CREATION_USES_RENAMES. This is necessary to use Git on Windows > >shared directories, and is already enabled for the MinGW and plain > >Windows builds. > I've been supporting use of git on cygwin since about 2008, this issue has > never risen that I know. Whatever issue is being patched around here, if > truly repeatable, should be handled by the cygwin dll as that code is > focused on providing full linux compatibility. If git on linux does need > this patch, git on cygwin should not, either. So, I vote against this. We've gotten a lot of users on the list who ask why their Git directories on shared drives aren't working (or are broken in some way). Since I don't use Windows, let me ask: does the Cygwin DLL handle link(2) properly on shared drives, and if not, would this patch help it do so? I can imagine that perhaps SMB doesn't support the necessary operations to make a POSIX link(2) work properly. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187