From: Jeff King <peff@peff.net>
To: Mike Hommey <mh@glandium.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johan Herland <johan@herland.net>
Subject: Re: [PATCH] notes: Use get_sha1_committish instead of read_ref in init_notes()
Date: Wed, 17 Jun 2015 12:35:36 -0400 [thread overview]
Message-ID: <20150617163536.GA22689@peff.net> (raw)
In-Reply-To: <20150617090246.GC30948@glandium.org>
On Wed, Jun 17, 2015 at 06:02:46PM +0900, Mike Hommey wrote:
> > In a sense that is weirdly broken already:
> >
> > $ git log --notes=:/foo >/dev/null
> > warning: notes ref refs/notes/:/foo is invalid
> >
> > but I wonder if we should be making expand_notes_ref a little more
> > careful as part of the same topic.
>
> Interestingly, now that I look, there's also this:
> https://github.com/git/git/blob/master/notes-cache.c#L40
>
> that doesn't use expand_notes_ref, but it's apparently only used in
> userdiff_get_textconv, and I'm not sure why.
notes-cache.c predates expand_notes_ref. I don't think it's a big deal.
The implementation of notes-cache is an internal detail (the user
interacts with it by setting diff.*.cacheTextConv, and then git handles
the cache).
-Peff
prev parent reply other threads:[~2015-06-17 16:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 1:15 [PATCH] notes: Use get_sha1_committish instead of read_ref in init_notes() Mike Hommey
2015-06-17 3:17 ` Junio C Hamano
2015-06-17 9:40 ` Mike Hommey
2015-06-17 15:18 ` Junio C Hamano
2015-06-17 16:35 ` Johan Herland
2015-07-08 10:21 ` [PATCH v2 - RFH] notes: Allow committish expressions as notes ref Mike Hommey
2015-07-09 2:48 ` [PATCH v3] " Mike Hommey
2015-07-10 1:03 ` Johan Herland
2015-07-10 1:28 ` [PATCH v4] notes: Allow treeish " Mike Hommey
2015-07-10 7:16 ` Johan Herland
2015-07-10 7:22 ` Mike Hommey
2015-07-10 8:39 ` [PATCH] " Mike Hommey
2015-07-13 16:35 ` Junio C Hamano
2015-07-13 20:53 ` Mike Hommey
2015-07-13 21:15 ` Junio C Hamano
2015-10-08 2:50 ` Mike Hommey
2015-10-08 2:54 ` [PATCH v6] notes: allow " Mike Hommey
2015-10-08 19:03 ` [PATCH] notes: Allow " Junio C Hamano
2015-07-13 21:19 ` Junio C Hamano
2015-06-17 3:22 ` [PATCH] notes: Use get_sha1_committish instead of read_ref in init_notes() Jeff King
2015-06-17 9:02 ` Mike Hommey
2015-06-17 16:35 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617163536.GA22689@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=mh@glandium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).