From: Jeff King <peff@peff.net>
To: Christian Couder <christian.couder@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"SZEDER Gábor" <szeder@ira.uka.de>, git <git@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] config: add options to list only variable names
Date: Fri, 29 May 2015 07:39:43 -0400 [thread overview]
Message-ID: <20150529113942.GA30503@peff.net> (raw)
In-Reply-To: <CAP8UFD2Zhomk+ryRfZFWAVs0yZeXUfpBXTo51Cm=Lj1QbkRbmA@mail.gmail.com>
On Fri, May 29, 2015 at 01:34:50PM +0200, Christian Couder wrote:
> >> +--get-name-regexp::
> >> + Like --get-regexp, but shows only matching variable names, not its
> >> + values.
> >
> > which makes it clear why it is needed. The distinction is purely
> > about the output, i.e. the values are omitted.
>
> If the distinction is purely about the output, then it seems logical
> to add only an output related option, like the --name-only option I
> suggested, and not 2 new modes (--get-name-regexp and --list-names).
>
> Doesn't it look like git config already has too many modes?
Yeah, I'd agree that is a simpler way to look at it, and avoiding extra
modes is probably a good thing.
-Peff
next prev parent reply other threads:[~2015-05-29 11:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 20:07 [PATCH 1/2] config: add options to list only variable names SZEDER Gábor
2015-05-27 20:07 ` [PATCH 2/2] completion: use new 'git config' options to reliably list " SZEDER Gábor
2015-05-27 20:11 ` [PATCH 1.5/2] config: add options to list only " SZEDER Gábor
2015-05-28 12:06 ` Christian Couder
2015-05-27 21:05 ` [PATCH 2/2] completion: use new 'git config' options to reliably list " Jeff King
2015-05-27 21:04 ` [PATCH 1/2] config: add options to list only " Jeff King
2015-05-27 21:08 ` Jeff King
2015-05-27 21:34 ` SZEDER Gábor
2015-05-27 22:20 ` Junio C Hamano
2015-05-28 12:29 ` [PATCH v2 0/2] config: list only variable names for completion SZEDER Gábor
2015-05-28 12:29 ` [PATCH v2 1/2] config: add options to list only variable names SZEDER Gábor
2015-05-28 19:20 ` Junio C Hamano
2015-05-28 19:36 ` Junio C Hamano
2015-05-29 11:34 ` Christian Couder
2015-05-29 11:39 ` Jeff King [this message]
2015-05-28 12:29 ` [PATCH v2 2/2] completion: use new 'git config' options to reliably list " SZEDER Gábor
2015-05-28 20:39 ` [PATCH v2 0/2] config: list only variable names for completion Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529113942.GA30503@peff.net \
--to=peff@peff.net \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).