From: Heiko Voigt <hvoigt@hvoigt.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jens Lehmann <jens.lehmann@web.de>,
Jonathan Nieder <jrnieder@gmail.com>, Jeff King <peff@peff.net>,
"W. Trevor King" <wking@tremily.us>,
Karsten Blees <karsten.blees@gmail.com>
Subject: Re: Re: [PATCH v3 0/4] submodule config lookup API
Date: Tue, 26 May 2015 17:24:02 +0200 [thread overview]
Message-ID: <20150526152402.GA31115@book.hvoigt.net> (raw)
In-Reply-To: <555E28E3.5020003@web.de>
On Thu, May 21, 2015 at 08:50:11PM +0200, René Scharfe wrote:
> Am 21.05.2015 um 19:06 schrieb Heiko Voigt:
> >diff --git a/submodule-config.h b/submodule-config.h
> >index 9061e4e..58afc83 100644
> >--- a/submodule-config.h
> >+++ b/submodule-config.h
> >@@ -24,6 +24,6 @@ const struct submodule *submodule_from_name(const unsigned char *commit_sha1,
> > const char *name);
> > const struct submodule *submodule_from_path(const unsigned char *commit_sha1,
> > const char *path);
> >-void submodule_free(void);
> >+void submodule_free();
>
> Why this change? With void it matches the function's definition.
Sorry oversight on my side will remove it. Junio added those on his side
but it seems I forgot it in the header.
Cheers Heiko
prev parent reply other threads:[~2015-05-26 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 17:06 [PATCH v3 0/4] submodule config lookup API Heiko Voigt
2015-05-21 17:07 ` [PATCH v3 1/4] implement submodule config cache for lookup of submodule names Heiko Voigt
2015-05-21 17:08 ` [PATCH v3 2/4] extract functions for submodule config set and lookup Heiko Voigt
2015-05-21 17:08 ` [PATCH v3 3/4] use new config API for worktree configurations of submodules Heiko Voigt
2015-05-21 17:09 ` [PATCH v3 4/4] do not die on error of parsing fetchrecursesubmodules option Heiko Voigt
2015-05-21 18:40 ` [PATCH v3 0/4] submodule config lookup API Junio C Hamano
2015-05-26 15:46 ` Heiko Voigt
2015-05-21 18:50 ` René Scharfe
2015-05-26 15:24 ` Heiko Voigt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526152402.GA31115@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jens.lehmann@web.de \
--cc=jrnieder@gmail.com \
--cc=karsten.blees@gmail.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).