From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Occasional wrong behavior of rev-walking (rev-list, log, etc.)
Date: Fri, 22 May 2015 07:49:56 +0900 [thread overview]
Message-ID: <20150521224956.GA23810@glandium.org> (raw)
In-Reply-To: <xmqq617llw6k.fsf@gitster.dls.corp.google.com>
On Thu, May 21, 2015 at 09:41:55AM -0700, Junio C Hamano wrote:
> Mike Hommey <mh@glandium.org> writes:
>
> > My guess is that rev-walking is tripping on the fact that this repository
> > has commit dates in random order.
>
> Yeah, that is well known (look for SLOP both in the code and list
> archive).
I found the recent thread about git describe --contains. (and now I
realize this is also why git describe --contains doesn't work quite well
for the same repository).
Now the question is what can we done in the short term? (short of
introducing something like generation numbers) I tried increasing
SLOP and to remove the date check (with the hope that making one or
both configurable might help). Neither fixed the particular test
case I started this thread with.
Mike
next prev parent reply other threads:[~2015-05-21 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 6:15 Occasional wrong behavior of rev-walking (rev-list, log, etc.) Mike Hommey
2015-05-21 16:41 ` Junio C Hamano
2015-05-21 22:49 ` Mike Hommey [this message]
2015-05-21 22:59 ` Junio C Hamano
2015-05-22 0:57 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521224956.GA23810@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).