From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Faheem Mitha <faheem@faheem.info>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PUB]corrupt repos does not return error with `git fsck`
Date: Wed, 20 May 2015 14:31:15 -0400 [thread overview]
Message-ID: <20150520183115.GB7142@peff.net> (raw)
In-Reply-To: <20150520182218.GD14561@peff.net>
On Wed, May 20, 2015 at 02:22:19PM -0400, Jeff King wrote:
> On Wed, May 20, 2015 at 11:02:14AM -0700, Stefan Beller wrote:
>
> > $ git clone https://github.com/fmitha/SICL
> > cd SICL
> > $ git show 280c12ab49223c64c6f914944287a7d049cf4dd0
> > fatal: bad object 280c12ab49223c64c6f914944287a7d049cf4dd0
> > $ git show 12323213123 # just to be sure to have a different error
> > message for non existing objects.
> > fatal: ambiguous argument '12323213123': unknown revision or path not
> > in the working tree.
>
> Yeah, this is well-known. If you give a partial hash, the error comes
> from get_sha1(), which says "hey, this doesn't look like anything I know
> about". If you feed a whole hash, we skip all that and say "well, you
> _definitely_ meant this sha1", and then later code complains when it
> cannot be read.
>
> We could add a has_sha1_file() check in get_sha1 for this case. I can't
> think offhand of any reason it would need to be called with a
> non-existent object, but there may be some lurking corner case (e.g.,
> "cat-file -e" or something).
I should have looked before replying. It would indeed break "cat-file
-e" horribly. So the right answer may be to just improve the "bad
object" message (probably by checking has_sha1_file there and diagnosing
it either as missing or corrupted).
-Peff
next prev parent reply other threads:[~2015-05-20 18:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 16:17 corrupt repos does not return error with `git fsck` Faheem Mitha
2015-05-20 17:19 ` [PUB]corrupt " Matthieu Moy
2015-05-20 17:40 ` Johannes Schindelin
2015-05-20 18:02 ` Stefan Beller
2015-05-20 18:19 ` John Keeping
2015-05-20 18:22 ` Jeff King
2015-05-20 18:31 ` Jeff King [this message]
2015-05-20 20:39 ` Junio C Hamano
2015-05-20 20:57 ` Stefan Beller
2015-05-20 21:06 ` Junio C Hamano
2015-05-20 21:13 ` Stefan Beller
2015-05-20 21:55 ` Jeff King
2015-05-20 20:16 ` Junio C Hamano
2015-05-20 18:24 ` Faheem Mitha
2015-05-20 18:54 ` Stefan Beller
2015-05-20 19:13 ` Faheem Mitha
2015-05-20 21:03 ` Matthieu Moy
2015-05-20 17:58 ` Faheem Mitha
2015-05-21 8:09 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520183115.GB7142@peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=faheem@faheem.info \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).