git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Luis Ressel <aranea@aixah.de>
To: <git@vger.kernel.org>
Cc: Christian Couder <christian.couder@gmail.com>,
	Paul Tan <pyokagan@gmail.com>
Subject: Re: [GSoC microproject] Add XDG support to the credential-store helper
Date: Fri, 6 Mar 2015 00:41:39 +0100	[thread overview]
Message-ID: <20150306004139.2dac2502@gentp.lnet> (raw)
In-Reply-To: <20150306001534.06882282@gentp.lnet>

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

Okay, I've had a look at Paul's patch for this. Sorry again for the
dupe, I must've missed it before. I guess I'll attempt another
microproject.

However, I feel like my patch is really all that's neccessary; I don't
think we should try to use both files if they exist -- I consider
Paul's approach to be a bit overcomplicated.

My patch still uses ~/.git-credentials as a default location, which
should be sufficient for compability. A user that wants to use
~/.config/git/credentials instead has to manually create that file
first, which he just shouldn't do if he has to stay compatible to
previous git versions.

Of course, my patch is definitly lacking a test case, and the
documentation could be a tad better, too.


Regards,
Luis Ressel

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

  reply	other threads:[~2015-03-05 23:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05 20:51 [GSoC microproject] Add XDG support to the credential-store helper Luis Ressel
2015-03-05 20:53 ` [PATCH] " Luis Ressel
2015-03-05 22:10 ` [GSoC microproject] " Junio C Hamano
2015-03-05 22:38 ` Christian Couder
2015-03-05 23:15   ` Luis Ressel
2015-03-05 23:41     ` Luis Ressel [this message]
2015-03-06  8:04       ` Paul Tan
2015-03-06 17:28         ` Matthieu Moy
2015-03-06 19:21           ` Paul Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150306004139.2dac2502@gentp.lnet \
    --to=aranea@aixah.de \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pyokagan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).