From: "H.Merijn Brand" <h.m.brand@xs4all.nl>
To: Jeff King <peff@peff.net>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: Interested in helping open source friends on HP-UX?
Date: Fri, 20 Feb 2015 12:24:07 +0100 [thread overview]
Message-ID: <20150220122407.4183490b@pc09.procura.nl> (raw)
In-Reply-To: <20150220104921.GA2467@peff.net>
[-- Attachment #1: Type: text/plain, Size: 2920 bytes --]
On Fri, 20 Feb 2015 05:49:21 -0500, Jeff King <peff@peff.net> wrote:
> On Fri, Feb 20, 2015 at 11:36:27AM +0100, Michael J Gruber wrote:
>
> > > It's not quite so bad as you make out. We write the value to the
> > > GIT-BUILD-OPTIONS file during "make", no matter where it comes from, and
> > > load that in test-lib.sh. So:
> > >
> > > make NO_ICONV=Nope
> > > cd t
> > > ./t3901-i18n-patch.sh
> > >
> > > works just fine (for this and for any of the other options we mark
> > > there).
> >
> > It survives a cd, sure...
>
> I think the interesting thing is that it survives running `./tXXXX`
> rather than running the test through make.
I always use prove
$ prove -v t1234.sh
> > Now, change your config.mak before the cd and
> > forget the make. Not everyone does
> >
> > make -C t t3901-i18n-patch.sh
> >
> > Though, having just discovered that shell completion works for that
> > form, too, I may do it more often (and then complain about having to use
> > GIT_TEST_OPTS ;) )
>
> Yeah, I never use "make tXXXX" myself. But nor would I expect the tests
> to respect a version of git I had not actually built. E.g., if you build
> with NO_PERL, and then remove NO_PERL from your config.mak but do _not_
> actually run "make", should that work? Ditto for NO_ICONV, for that
> matter. The tests must match the binary, and the best guess we have
> about the binary is the last thing we built.
>
> Adding "git --build-options" would give us a better guess (it may not be
> what the user _wanted_ to test, but it is what they _are_ testing).
>
> > > I suspect GIT_TEST_INSTALLED is not all that widely used, or somebody
> > > would have complained before. But if we really want to support it, I
> > > think the right thing is to bake GIT-BUILD-OPTIONS into the binary, so
> > > that "git --build-options" dumps it. It might also have value for
> > > debugging and forensics in general.
> >
> > Yep, that would be helpful in general. I don't think we should worry
> > about GIT_TEST_INSTALLED too much. Who came up with that feature anyway...?
>
> Clearly a crazy person. :) I am not saying it is a _bad_ idea. Only that
> the responsibility to make sure the installed version matches the
> current build parameters lies with the user (and for that matter, the
> current set of tests; we add new tests that would fail on old versions,
> and you cannot mix and match).
>
> So an alternate explanation than "not widely used" is "all of the users
> of it are responsible individuals who do not make bogus bug reports to
> the list". :)
>
> -Peff
--
H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/
using perl5.00307 .. 5.21 porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2015-02-20 11:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 7:46 Interested in helping open source friends on HP-UX? Junio C Hamano
2015-02-18 16:00 ` H.Merijn Brand
2015-02-18 17:46 ` Michael J Gruber
2015-02-18 18:25 ` Jeff King
2015-02-18 18:47 ` Junio C Hamano
2015-02-18 18:57 ` Jeff King
2015-02-19 10:33 ` Michael J Gruber
2015-02-19 11:14 ` H.Merijn Brand
2015-02-19 11:20 ` Michael J Gruber
2015-02-19 12:54 ` Jeff King
2015-02-19 13:21 ` Michael J Gruber
2015-02-19 18:56 ` H.Merijn Brand
2015-03-03 14:55 ` Michael J Gruber
2015-03-03 15:30 ` H.Merijn Brand
2015-03-03 16:05 ` Michael J Gruber
2015-03-03 22:25 ` H.Merijn Brand
2015-02-20 1:48 ` Jeff King
2015-02-20 10:36 ` Michael J Gruber
2015-02-20 10:49 ` Jeff King
2015-02-20 11:24 ` H.Merijn Brand [this message]
2015-02-18 19:22 ` H.Merijn Brand
2015-02-18 19:20 ` H.Merijn Brand
2015-02-21 23:31 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220122407.4183490b@pc09.procura.nl \
--to=h.m.brand@xs4all.nl \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).