From: David Aguilar <davvid@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>,
git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"René Scharfe" <l.s.r@web.de>
Subject: Re: [RFC PATCH v2 1/2] Makefile: add check-headers target
Date: Tue, 9 Sep 2014 17:03:29 -0700 [thread overview]
Message-ID: <20140910000328.GB12644@gmail.com> (raw)
In-Reply-To: <xmqqa969nav9.fsf@gitster.dls.corp.google.com>
On Mon, Sep 08, 2014 at 12:57:46PM -0700, Junio C Hamano wrote:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
> > Junio C Hamano <gitster@pobox.com> writes:
> >
> >> David Aguilar <davvid@gmail.com> writes:
> >>
> >>> +IFS='
> >>> +'
> >>> +git ls-files *.h ewah/*.h vcs-svn/*.h xdiff/*.h |
> >>
> >> Hmm. This is only for true developers (not one who merely compiles
> >> after expanding a tarball), so "git ls-files" may probably be OK.
> >>
> >> But "/bin/ls" would be equally fine for that, no?
> >
> > Actually, since this is "| while read header", I have to wonder why this
> > is not written as
> >
> > for header in .h ewah/*.h vcs-svn/*.h xdiff/*.h
> > do
> > ...
> > done
>
> Yes, that would be even better. Then you wouldn't even have to
> worry about $IFS dance.
The original motivation was to avoid picking up the generated
common-cmds.h header file.
It was the N_() function that was messing it up.
Would it make sense to split out a separate patch that makes common-cmds.h
check-headers clean?
--
David
next prev parent reply other threads:[~2014-09-10 0:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 0:30 [RFC PATCH v2 1/2] Makefile: add check-headers target David Aguilar
2014-09-07 0:30 ` [RFC PATCH v2 2/2] headers: include dependent headers David Aguilar
2014-09-07 6:41 ` René Scharfe
2014-09-07 19:49 ` Jonathan Nieder
2014-09-07 19:54 ` Johannes Sixt
2014-09-07 20:01 ` Jonathan Nieder
2014-09-07 20:30 ` David Aguilar
2014-09-07 19:42 ` [RFC PATCH v2 1/2] Makefile: add check-headers target Jonathan Nieder
2014-09-08 18:56 ` Junio C Hamano
2014-09-08 19:29 ` Matthieu Moy
2014-09-08 19:57 ` Junio C Hamano
2014-09-10 0:03 ` David Aguilar [this message]
2014-09-10 17:09 ` Junio C Hamano
2014-09-10 17:24 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910000328.GB12644@gmail.com \
--to=davvid@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).