From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Duy Nguyen <pclouds@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v3] teach fast-export an --anonymize option
Date: Sun, 31 Aug 2014 11:53:51 -0400 [thread overview]
Message-ID: <20140831155350.GE17449@peff.net> (raw)
In-Reply-To: <CAPig+cSKfxAsr+RQp8N8GAOe9fa_6kGPi_-X99Vs-2bYbBoC8A@mail.gmail.com>
On Sun, Aug 31, 2014 at 06:34:08AM -0400, Eric Sunshine wrote:
> >> I feel like this should be part of git-fast-export.txt, just to
> >> increase the user's confidence in the tool (and I don't expect most
> >> users to read this commit message).
> >
> > Hmph. Whenever I say "I think this patch is done", suddenly the comments
> > start pouring in. :)
>
> Considering that the value of --anonymize is not yet known, is such an
> invasive change to fast-export.c warranted? Would it make sense
> instead to provide "anonymize" functionality as a contrib/ script or a
> distinct git-anonymize-foo command which accepts a fast-import stream
> as input and anonymizes it as output?
I considered that, but there's a non-trivial amount of work in the
parsing of the stream (I had originally thought to just ship a perl
script to operate on the stream). And while there's a fair bit of code
added to fast-export.c, none of it is ever called unless --anonymize is
set.
So while I am not 100% sure that the idea is a good one, I do not think
it is hurting the current fast-export in any meaningful way. Two things
we could do to minimize that are:
1. Move the anonymization code into a separate C file to keep the
fast-export source a little more pristine. I avoided doing this
just because the interfaces to the functions are fairly tailored to
what fast-export wants.
2. Have a separate git-anonymize command which is basically running
"git fast-export --anonymize" under the hood. This avoids polluting
fast-export from the user's perspective (they do not need to care
that it is running fast-export under the hood).
-Peff
prev parent reply other threads:[~2014-08-31 15:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 7:01 [PATCH] teach fast-export an --anonymize option Jeff King
2014-08-21 20:15 ` Junio C Hamano
2014-08-21 22:41 ` Jeff King
2014-08-21 21:57 ` Junio C Hamano
2014-08-21 22:49 ` Jeff King
2014-08-21 23:21 ` [PATCH v2] " Jeff King
2014-08-22 13:06 ` Duy Nguyen
2014-08-22 18:39 ` Philip Oakley
2014-08-23 6:19 ` Jeff King
2014-08-27 16:01 ` Junio C Hamano
2014-08-27 16:58 ` Jeff King
2014-08-27 17:01 ` [PATCH v3] " Jeff King
2014-08-28 10:30 ` Duy Nguyen
2014-08-28 12:32 ` Jeff King
2014-08-28 16:46 ` Ramsay Jones
2014-08-28 18:43 ` Junio C Hamano
2014-08-28 18:50 ` Jeff King
2014-08-28 18:11 ` Junio C Hamano
2014-08-28 19:04 ` Jeff King
2014-08-31 10:34 ` Eric Sunshine
2014-08-31 15:53 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140831155350.GE17449@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).