* [PATCH] Document LF appearing in shallow command during send-pack/receive-pack
@ 2014-08-27 20:46 Shawn Pearce
2014-08-27 22:10 ` Jonathan Nieder
0 siblings, 1 reply; 2+ messages in thread
From: Shawn Pearce @ 2014-08-27 20:46 UTC (permalink / raw
To: Junio C Hamano; +Cc: git
The implementation sends an LF, but the protocol documentation was
missing this detail.
Signed-off-by: Shawn Pearce <spearce@spearce.org>
---
Documentation/technical/pack-protocol.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt
index 18dea8d..569c48a 100644
--- a/Documentation/technical/pack-protocol.txt
+++ b/Documentation/technical/pack-protocol.txt
@@ -467,7 +467,7 @@ references.
----
update-request = *shallow command-list [pack-file]
- shallow = PKT-LINE("shallow" SP obj-id)
+ shallow = PKT-LINE("shallow" SP obj-id LF)
command-list = PKT-LINE(command NUL capability-list LF)
*PKT-LINE(command LF)
--
2.1.0.rc2.206.gedb03e5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Document LF appearing in shallow command during send-pack/receive-pack
2014-08-27 20:46 [PATCH] Document LF appearing in shallow command during send-pack/receive-pack Shawn Pearce
@ 2014-08-27 22:10 ` Jonathan Nieder
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Nieder @ 2014-08-27 22:10 UTC (permalink / raw
To: Shawn Pearce; +Cc: Junio C Hamano, git, Nguyễn Thái Ngọc Duy
Shawn Pearce wrote:
> The implementation sends an LF, but the protocol documentation was
> missing this detail.
>
> Signed-off-by: Shawn Pearce <spearce@spearce.org>
> ---
> Documentation/technical/pack-protocol.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt
> index 18dea8d..569c48a 100644
> --- a/Documentation/technical/pack-protocol.txt
> +++ b/Documentation/technical/pack-protocol.txt
> @@ -467,7 +467,7 @@ references.
> ----
> update-request = *shallow command-list [pack-file]
>
> - shallow = PKT-LINE("shallow" SP obj-id)
> + shallow = PKT-LINE("shallow" SP obj-id LF)
In git, the client sends LF and the server is happy with or
without LF. JGit and libgit2 don't send 'shallow' lines.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> command-list = PKT-LINE(command NUL capability-list LF)
> *PKT-LINE(command LF)
> --
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-27 22:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-27 20:46 [PATCH] Document LF appearing in shallow command during send-pack/receive-pack Shawn Pearce
2014-08-27 22:10 ` Jonathan Nieder
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).