From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: Re: [PATCH 8/8] perf: add tests for tag --contains
Date: Wed, 25 Jun 2014 20:01:29 -0400 [thread overview]
Message-ID: <20140626000129.GA25028@sigill.intra.peff.net> (raw)
In-Reply-To: <20140625235335.GH23146@sigill.intra.peff.net>
On Wed, Jun 25, 2014 at 07:53:35PM -0400, Jeff King wrote:
> There are still two things about the timings that puzzle me a bit.
<forehead-palm>
This certainly isn't helping:
> +test_expect_success 'find reference points' '
> + recent=$(git rev-parse HEAD~100) &&
> + old=$(git rev-parse HEAD~5000) &&
> + ancient=$(git rev-list | tail -n 1)
> +'
$ancient will always be empty, as rev-list needs a "HEAD" argument.
I also think HEAD~100 is probably _too_ recent, as it is not enough to
match any tags at all right now.
So with this patch:
diff --git a/t/perf/p7000-tag-contains.sh b/t/perf/p7000-tag-contains.sh
index 846f106..8294d41 100755
--- a/t/perf/p7000-tag-contains.sh
+++ b/t/perf/p7000-tag-contains.sh
@@ -6,9 +6,9 @@ test_description='speed of tag --contains lookups'
test_perf_default_repo
test_expect_success 'find reference points' '
- recent=$(git rev-parse HEAD~100) &&
+ recent=$(git rev-parse HEAD~200) &&
old=$(git rev-parse HEAD~5000) &&
- ancient=$(git rev-list | tail -n 1)
+ ancient=$(git rev-list HEAD | tail -n 1)
'
test_expect_success 'find most recent tag' '
I get:
Test ffc4b80^ origin/master HEAD
----------------------------------------------------------------------------------------------------
7000.3: contains recent/all 1.99(1.97+0.01) 0.25(0.24+0.00) -87.4% 0.27(0.26+0.00) -86.4%
7000.4: contains recent/v2.0.1 0.03(0.03+0.00) 0.00(0.00+0.00) -100.0% 0.03(0.02+0.00) +0.0%
7000.5: contains old/all 0.90(0.89+0.00) 0.18(0.17+0.00) -80.0% 0.27(0.26+0.00) -70.0%
7000.6: contains old/v2.0.1 0.25(0.24+0.00) 0.03(0.03+0.00) -88.0% 0.25(0.24+0.00) +0.0%
7000.7: contains ancient/all 0.82(0.80+0.01) 0.13(0.12+0.00) -84.1% 0.27(0.26+0.01) -67.1%
7000.8: contains ancient/v2.0.1 0.26(0.26+0.00) 0.09(0.08+0.00) -65.4% 0.25(0.24+0.00) -3.8%
which looks about right.
-Peff
next prev parent reply other threads:[~2014-06-26 0:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 23:34 [PATCH 0/8] use merge-base for tag --contains Jeff King
2014-06-25 23:35 ` [PATCH 1/8] tag: allow --sort with -n Jeff King
2014-06-25 23:35 ` [PATCH 2/8] tag: factor out decision to stream tags Jeff King
2014-06-25 23:39 ` [PATCH 3/8] paint_down_to_common: use prio_queue Jeff King
2014-07-01 16:23 ` Junio C Hamano
2014-07-01 17:10 ` Jeff King
2014-06-25 23:40 ` [PATCH 4/8] add functions for memory-efficient bitmaps Jeff King
2014-06-26 3:15 ` Torsten Bögershausen
2014-06-26 15:51 ` Jeff King
2014-06-29 7:41 ` Eric Sunshine
2014-06-30 17:07 ` Jeff King
2014-07-01 16:57 ` Junio C Hamano
2014-07-01 17:18 ` Jeff King
2014-06-25 23:42 ` [PATCH 5/8] string-list: add pos to iterator callback Jeff King
2014-07-01 17:45 ` Junio C Hamano
2014-07-01 19:00 ` Jeff King
2014-06-25 23:47 ` [PATCH 6/8] commit: provide a fast multi-tip contains function Jeff King
2014-06-26 18:55 ` Junio C Hamano
2014-06-26 19:19 ` Junio C Hamano
2014-06-26 19:26 ` Junio C Hamano
2014-07-01 18:16 ` Junio C Hamano
2014-07-01 19:14 ` Junio C Hamano
2014-06-25 23:49 ` [PATCH 7/8] tag: use commit_contains Jeff King
2014-06-25 23:53 ` [PATCH 8/8] perf: add tests for tag --contains Jeff King
2014-06-26 0:01 ` Jeff King [this message]
2014-06-26 0:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626000129.GA25028@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).