From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeremiah Mahler <jmmahler@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] add strnncmp() function
Date: Mon, 16 Jun 2014 13:16:44 -0700 [thread overview]
Message-ID: <20140616201644.GN8557@google.com> (raw)
In-Reply-To: <58e0ac866bdeb8cc6e06cf553a459af351ccfd1b.1402945507.git.jmmahler@gmail.com>
Jeremiah Mahler wrote:
> Add a strnncmp() function which behaves like strncmp() except it uses
> the length of both strings instead of just one.
The above description isn't very clear to me. Problems:
- strncmp compares prefixes of \0-terminated strings. This function
compares two binary buffers which can contain \0
- strncmp is a comparison function and can even be used with functions
like qsort (for operations like "sort on the first two characters").
This function returns 0 or nonzero.
Would something like
/* true if buffers have the same length and are byte-for-byte identical */
int bufeq(const char *, int, const char *, int);
(or buf_equal, array_equal etc) make sense?
next prev parent reply other threads:[~2014-06-16 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 19:13 [PATCH 0/3] add strnncmp() function Jeremiah Mahler
2014-06-16 19:13 ` [PATCH 1/3] " Jeremiah Mahler
2014-06-16 20:16 ` Jonathan Nieder [this message]
2014-06-16 19:13 ` [PATCH 2/3] tree-walk: simplify via strnncmp() Jeremiah Mahler
2014-06-16 20:18 ` Jonathan Nieder
2014-06-17 7:13 ` Jeremiah Mahler
2014-06-16 19:13 ` [PATCH 3/3] unpack-trees: " Jeremiah Mahler
2014-06-16 20:19 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616201644.GN8557@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jmmahler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).