From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: David Aguilar <davvid@gmail.com>
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>,
Paul Mackerras <paulus@samba.org>,
git@vger.kernel.org
Subject: Re: [PATCH] gitk: use mktemp -d to avoid predictable temporary directories
Date: Sun, 15 Jun 2014 22:16:32 +0000 [thread overview]
Message-ID: <20140615221632.GH368384@vauxhall.crustytoothpaste.net> (raw)
In-Reply-To: <20140615214928.GA619@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
On Sun, Jun 15, 2014 at 02:49:29PM -0700, David Aguilar wrote:
> I don't think this requires a CVE since it's basically plugging a hole
> that my previous patch introduced by making gitk honor the TMPDIR
> variable; it hasn't strictly been in any release yet.
Yeah, that's not needed, then. I didn't notice it was the immediately
previous patch. My bad.
> Hmm.. I guess what I could do is keep the old behavior (having gitk
> ignore TMPDIR) on Windows and only use the new code path on
> non-Windows.
>
> That seems like it'd be the simplest implementation (no need to check
> versions) and the least harmful to existing users (avoids a tcl
> upgrade or mkdtemp installation for Windows users).
Yeah, that would be the safest bet. Maybe a comment to that effect
would be appropriate, so that when Tcl gets upgraded, that change can be
removed.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-15 22:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 21:43 [PATCH] gitk: use mktemp -d to avoid predictable temporary directories David Aguilar
2014-06-15 4:57 ` Paul Mackerras
2014-06-15 7:51 ` Pat Thoyts
2014-06-15 16:32 ` brian m. carlson
2014-06-15 21:49 ` David Aguilar
2014-06-15 22:16 ` brian m. carlson [this message]
2014-06-16 18:17 ` Junio C Hamano
2014-06-19 2:54 ` David Aguilar
2014-06-16 11:40 ` Thomas Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140615221632.GH368384@vauxhall.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=patthoyts@users.sourceforge.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).