From: Heiko Voigt <hvoigt@hvoigt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jens Lehmann <jens.lehmann@web.de>,
Jonathan Nieder <jrnieder@gmail.com>, Jeff King <peff@peff.net>
Subject: [PATCH 0/5] submodule config lookup API
Date: Thu, 5 Jun 2014 08:04:25 +0200 [thread overview]
Message-ID: <20140605060425.GA23874@sandbox-ub> (raw)
I have been holding back this series during the RC phase but now I think
it is ready for another round. The most important changes:
* The API is using a singleton now. No need to pass in the cache
object anymore.
* Local configuration can be looked up by passing in the null_sha1
* We use the API for existing lookup of submodule values
One open question:
* Since behind the scenes there is a global cache filled with the
values: Do we need to free it explicitely? Or is it ok to let it be
dealt with on exit?
The last iteration was here:
http://article.gmane.org/gmane.comp.version-control.git/243818
Heiko Voigt (5):
hashmap: add enum for hashmap free_entries option
implement submodule config cache for lookup of submodule names
extract functions for submodule config set and lookup
use new config API for worktree configurations of submodules
do not die on error of parsing fetchrecursesubmodules option
.gitignore | 1 +
Documentation/technical/api-hashmap.txt | 2 +-
Documentation/technical/api-submodule-config.txt | 63 ++++
Makefile | 2 +
builtin/checkout.c | 1 +
builtin/fetch.c | 1 +
diff.c | 1 +
diffcore-rename.c | 2 +-
hashmap.c | 2 +-
hashmap.h | 8 +-
name-hash.c | 4 +-
submodule-config.c | 435 +++++++++++++++++++++++
submodule-config.h | 29 ++
submodule.c | 122 ++-----
submodule.h | 4 +-
t/t7410-submodule-config.sh | 141 ++++++++
test-hashmap.c | 6 +-
test-submodule-config.c | 74 ++++
18 files changed, 791 insertions(+), 107 deletions(-)
create mode 100644 Documentation/technical/api-submodule-config.txt
create mode 100644 submodule-config.c
create mode 100644 submodule-config.h
create mode 100755 t/t7410-submodule-config.sh
create mode 100644 test-submodule-config.c
--
2.0.0
next reply other threads:[~2014-06-05 6:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 6:04 Heiko Voigt [this message]
2014-06-05 6:06 ` [PATCH 1/5] hashmap: add enum for hashmap free_entries option Heiko Voigt
2014-06-06 17:52 ` Karsten Blees
2014-06-10 10:17 ` Heiko Voigt
2014-06-11 9:12 ` Karsten Blees
2014-06-12 19:12 ` Junio C Hamano
2014-06-17 8:30 ` Karsten Blees
2014-06-17 19:04 ` Heiko Voigt
2014-06-17 22:19 ` Junio C Hamano
2014-06-05 6:07 ` [PATCH 2/5] implement submodule config cache for lookup of submodule names Heiko Voigt
2014-06-05 17:46 ` W. Trevor King
2014-06-06 5:20 ` Heiko Voigt
2014-06-08 9:04 ` Eric Sunshine
2014-06-10 10:19 ` Heiko Voigt
2014-06-12 21:58 ` Junio C Hamano
2014-06-13 22:37 ` Heiko Voigt
2014-06-05 6:08 ` [PATCH 3/5] extract functions for submodule config set and lookup Heiko Voigt
2014-06-05 6:09 ` [PATCH 4/5] use new config API for worktree configurations of submodules Heiko Voigt
2014-06-05 6:09 ` [PATCH 5/5] do not die on error of parsing fetchrecursesubmodules option Heiko Voigt
2014-06-12 21:59 ` [PATCH 0/5] submodule config lookup API Junio C Hamano
2014-06-13 22:41 ` Heiko Voigt
2014-06-16 17:58 ` Junio C Hamano
2014-06-17 19:00 ` Heiko Voigt
2014-06-12 22:04 ` Junio C Hamano
2014-06-13 7:13 ` Jens Lehmann
2014-06-13 17:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605060425.GA23874@sandbox-ub \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jens.lehmann@web.de \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).