From: Charles Bailey <cbailey32@bloomberg.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add extra logic required to detect endianness on Solaris
Date: Fri, 2 May 2014 08:49:17 +0100 [thread overview]
Message-ID: <20140502074917.GA25198@hashpling.org> (raw)
In-Reply-To: <xmqqa9b1coml.fsf@gitster.dls.corp.google.com>
On Thu, May 01, 2014 at 11:58:26AM -0700, Junio C Hamano wrote:
>
> This patch seems to address two unrelated issues in that.
>
> (1) The existing support does not help a platform where the
> convention is to define either _BIG_ENDIAN (with one leading
> underscore) or _LITTLE_ENDIAN and not both, which is Solaris
> but there may be others.
>
> (2) There may be __LITTLE_ENDIAN and __BIG_ENDIAN macros already
> defined on the platform. Or these may not have been defined at
> all. You avoid unconditionally redefing these.
>
> I find the latter iffy.
Yes, you are right. I think I was uncomfortable defining macros with
names reserved for the implementation even if the implementation didn't
seem to be using them. I think I made my patch less correct as a result.
Looking at the rest of the git source code we don't seem to use any of
these macros anywhere else so perhaps we could use macros specific to
GIT?
Let me follow up with an alternative patch.
Charles.
next prev parent reply other threads:[~2014-05-02 7:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 7:43 [PATCH] Add extra logic required to detect endianness on Solaris Charles Bailey
2014-05-01 18:58 ` Junio C Hamano
2014-05-01 19:18 ` Junio C Hamano
2014-05-01 19:22 ` Junio C Hamano
2014-05-02 7:49 ` Charles Bailey [this message]
2014-05-02 7:55 ` [PATCH] Detect endianness on more platforms that don't use BYTE_ORDER Charles Bailey
2014-05-02 16:48 ` Junio C Hamano
2014-05-02 16:58 ` Charles Bailey
2014-05-02 19:34 ` Junio C Hamano
2014-05-02 19:43 ` Junio C Hamano
2014-05-02 20:02 ` Charles Bailey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502074917.GA25198@hashpling.org \
--to=cbailey32@bloomberg.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).