From: Jonathan Nieder <jrnieder@gmail.com>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Johan Herland <johan@herland.net>,
git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.0.0-rc0
Date: Tue, 22 Apr 2014 11:58:29 -0700 [thread overview]
Message-ID: <20140422185829.GB15516@google.com> (raw)
In-Reply-To: <475e137b5095e45c92a87a9969f58f0@74d39fa044aa309eaea14b9f57fe79c>
Kyle J. McKay wrote:
> The problem with --prefix="" is this (from the Getopt::Long CHANGES file):
>
> Changes in version 2.37
> -----------------------
>
> * Bugfix: With gnu_compat, --foo= will no longer trigger "Option
> requires an argument" but return the empty string.
>
> The system I ran the tests on happens to have Getopt::Long version 2.35.
Thanks for catching it.
Getopt::Long was updated to 2.37 in perl 5.8.9 (in 5.8.8 it was
updated to 2.35). INSTALL still only recommends Perl 5.8 so that's an
issue.
> The --prefix="" option can be rewritten --prefix "" in both tests and then
> they pass.
Hm, perhaps we should introduce a 'no-prefix' option to work around
this.
> |diff --git a/git-svn.perl b/git-svn.perl
> |index 7349ffea..284f458a 100755
> |--- a/git-svn.perl
> |+++ b/git-svn.perl
> |@@ -149,7 +149,7 @@ my ($_trunk, @_tags, @_branches, $_stdlayout);
> my %icv;
> my %init_opts = ( 'template=s' => \$_template, 'shared:s' => \$_shared,
> 'trunk|T=s' => \$_trunk, 'tags|t=s@' => \@_tags,
> 'branches|b=s@' => \@_branches, 'prefix=s' => \$_prefix,
+ 'no-prefix' => sub { $_prefix = "" },
> 'stdlayout|s' => \$_stdlayout,
> 'minimize-url|m!' => \$Git::SVN::_minimize_url,
> 'no-metadata' => sub { $icv{noMetadata} = 1 },
That way, normal usage of --prefix would still be consistent with
other git commands that prefer the form with argument attached
(--prefix=foo, not --prefix foo; see gitcli(7)).
Thoughts?
Jonathan
next prev parent reply other threads:[~2014-04-22 18:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 19:37 [ANNOUNCE] Git v2.0.0-rc0 Junio C Hamano
2014-04-19 1:13 ` Johan Herland
2014-04-19 7:20 ` Junio C Hamano
2014-04-20 19:08 ` Felipe Contreras
2014-04-20 21:14 ` Junio C Hamano
2014-04-22 11:16 ` Kyle J. McKay
2014-04-22 18:58 ` Jonathan Nieder [this message]
2014-04-22 20:12 ` Junio C Hamano
2014-04-22 21:00 ` Jonathan Nieder
2014-04-22 21:26 ` Junio C Hamano
2014-04-22 22:11 ` Jonathan Nieder
2014-04-22 22:25 ` brian m. carlson
2014-04-22 22:47 ` Junio C Hamano
2014-04-23 7:33 ` Johan Herland
2014-04-23 16:40 ` Junio C Hamano
2014-04-22 19:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422185829.GB15516@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=mackyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).