Re: [GUILT 04/28] Allow "guilt import-commit" to run from a dir which contains spaces.

[Jeff Sipek <jeffpc@josefsipek.net>]

On Sun, Mar 23, 2014 at 08:57:08PM +0100, Per Cederqvist wrote:
> On Sun, Mar 23, 2014 at 6:04 PM, Jeff Sipek <jeffpc@josefsipek.net> wrote:
> 
> > On Fri, Mar 21, 2014 at 08:31:42AM +0100, Per Cederqvist wrote:
> >
> >> Signed-off-by: Per Cederqvist <cederp@opera.com>
> >> ---
> >>  guilt-import-commit | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/guilt-import-commit b/guilt-import-commit
> >> index 20dcee2..9488ded 100755
> >> --- a/guilt-import-commit
> >> +++ b/guilt-import-commit
> >> @@ -23,7 +23,7 @@ if ! must_commit_first; then
> >>  fi
> >>
> >>  disp "About to begin conversion..." >&2
> >> -disp "Current head: `cat $GIT_DIR/refs/heads/\`git_branch\``" >&2
> >> +disp "Current head: `cat \"$GIT_DIR\"/refs/heads/\`git_branch\``" >&2
> >
> > I wonder if it'd be better to use 'git rev-parse' here instead of looking at
> > the refs directly.
> >
> > IOW,
> >
> > disp "Current head: `git rev-parse \`git_branch\``" >&2
> 
> That is probably a good idea. I only made the minimum change
> required to get the test suite to pass.

I totally understand.

> > Maybe even $() instead of the inner `` to clean it up some more.
> 
> Yes, given that that construct is already used in several places
> it is apparently portable enough for guilt. (I guess nobody uses
> /bin/sh on Solaris to run guilt. It doesn't support the $(...)
> construct.)

Hrm?  I'm using OpenIndiana (OpenSolaris derivative) and my /bin/sh seems to
be a symlink to ksh93.  What version of Solaris are you seeing this behavior
on?

Jeff.

-- 
The reasonable man adapts himself to the world; the unreasonable one
persists in trying to adapt the world to himself. Therefore all progress
depends on the unreasonable man.
		- George Bernard Shaw