From mboxrd@z Thu Jan 1 00:00:00 1970 From: "brian m. carlson" Subject: Re: git 1.9.0 segfault Date: Sat, 8 Mar 2014 16:46:51 +0000 Message-ID: <20140308164651.GA32213@vauxhall.crustytoothpaste.net> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Cc: git@vger.kernel.org To: Guillaume Gelin X-From: git-owner@vger.kernel.org Sat Mar 08 17:47:26 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WMKPF-000377-Qt for gcvg-git-2@plane.gmane.org; Sat, 08 Mar 2014 17:47:26 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752107AbaCHQrS (ORCPT ); Sat, 8 Mar 2014 11:47:18 -0500 Received: from castro.crustytoothpaste.net ([173.11.243.49]:52412 "EHLO castro.crustytoothpaste.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbaCHQq4 (ORCPT ); Sat, 8 Mar 2014 11:46:56 -0500 Received: from vauxhall.crustytoothpaste.net (unknown [IPv6:2001:470:1f05:79:fdce:ca83:d79c:2d90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by castro.crustytoothpaste.net (Postfix) with ESMTPSA id 78DF428088; Sat, 8 Mar 2014 16:46:55 +0000 (UTC) Mail-Followup-To: Guillaume Gelin , git@vger.kernel.org Content-Disposition: inline In-Reply-To: X-Machine: Running on vauxhall using GNU/Linux on x86_64 (Linux kernel 3.12-1-amd64) User-Agent: Mutt/1.5.22 (2013-10-16) X-Spam-Score: -0.272 () BAYES_00,RDNS_NONE Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 08, 2014 at 04:23:43PM +0000, Guillaume Gelin wrote: > Hi, > > http://pastebin.com/Np7L54ar I can confirm this. I get the following backtrace: Core was generated by `/home/bmc/checkouts/git/git mv packages/ lisp'. Program terminated with signal 11, Segmentation fault. #0 0x00007fe31a4371b2 in _IO_vfprintf_internal (s=3Ds@entry=3D0x7fffa330= d2e0, format=3D, format@entry=3D0x7fffa330e5b0 "renaming '%s= ' failed: Bad address", ap=3Dap@entry=3D0x7fffa330e498) at vfprintf.c:1649 1649 vfprintf.c: No such file or directory. (gdb) bt #0 0x00007fe31a4371b2 in _IO_vfprintf_internal (s=3Ds@entry=3D0x7fffa330= d2e0, format=3D, format@entry=3D0x7fffa330e5b0 "renaming '%s= ' failed: Bad address", ap=3Dap@entry=3D0x7fffa330e498) at vfprintf.c:1649 #1 0x00007fe31a4e2315 in ___vsnprintf_chk (s=3Ds@entry=3D0x7fffa330d450 = "renaming '0\243\377\177", maxlen=3D, maxlen@entry=3D4096, f= lags=3Dflags@entry=3D1, slen=3Dslen@entry=3D4096, format=3D0x7fffa330e5b0 "renaming '%s' failed: Bad address", format@e= ntry=3D0x544fe5 "fatal: ", args=3D0x7fffa330e498) at vsnprintf_chk.c:63 #2 0x00000000005041cb in vsnprintf (__ap=3D, __fmt=3D0x54= 4fe5 "fatal: ", __n=3D4096, __s=3D0x7fffa330d450 "renaming '0\243\377\177")= at /usr/include/x86_64-linux-gnu/bits/stdio2.h:77 #3 vreportf (prefix=3Dprefix@entry=3D0x544fe5 "fatal: ", err=3D, params=3D) at usage.c:12 #4 0x0000000000504224 in die_builtin (err=3D, params=3D) at usage.c:36 #5 0x0000000000504650 in die_errno (fmt=3D0x52be9a "renaming '%s' failed= ") at usage.c:137 #6 0x000000000044cb4d in cmd_mv (argc=3D, argv=3D, prefix=3D) at builtin/mv.c:246 #7 0x000000000040602d in run_builtin (argv=3D0x7fffa330ef90, argc=3D3, p= =3D0x779d40 ) at git.c:314 #8 handle_builtin (argc=3D3, argv=3D0x7fffa330ef90) at git.c:487 #9 0x00000000004052e1 in run_argv (argv=3D0x7fffa330ee48, argcp=3D0x7fff= a330ee2c) at git.c:533 #10 main (argc=3D3, av=3D) at git.c:616 We're failing to rename because we got an EFAULT, and then we try to print the failing filename, and we get a segfault right here: if (rename(src, dst) < 0 && !ignore_errors) die_errno (_("renaming '%s' failed"), src); I don't know yet if dst is also bad, but clearly src is. I'm looking into it. --=20 brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187 --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJTG0l7AAoJEL9TXYEfUvaL9KMQALqUDMkul3LVHnQ82Mlr0pwX cGmFcQs4Ag+ePpl7FvxohtfT5XOERI+wRbFN4X8pHEnBnJe+4nu5xfJH7X7WZcFl aQVOWhRFXyjW3BwdAnWMkb+slfgqXKjmzV+NuqoIL7YNMXQzGYirzbG2dRwv+48I dfd5l7LZF+4gs8mHDBOQauqrWkv91TPJecDloowS0kTYZjCLrxZJvvV+HrIdELtC PvyrdjqGpFTj+szSSYLn8HR4JCA8D5p4x9y0Hfsx+dHSXPAOX6x287+AUWrjcIqV sVHt1apxQhm0+bzf3U1QXiQkeiAOuD6Hc6U9+Kra1t0AvvMm2DCdX/L8lJ2oedLU 9PzoqE7Ddj18Juy8FI252sNFfpX5WNDiqm/4L4u3FXndl7XJm0cyG4g/+zDE64fx iJ1FVKFt4iL+ezDnSPVJH9OCTeD+tBPgsIJ9/wdD2deqhOSkxSAod6GQ7n/59TbG JDkSdoxyWHT84dq/7C1d1+kPMRsS8JBs8+MPky0wRhoBS32OsSXQfGUQe9WklWxJ nphCwMJ3AyB6sc3c2Rsb1B2CuRdjGpA7eEo6kE7cUSWVz15hbGUgzjv4ZwfVbMBt LH+u341/Kqi7Mr2vXe4FNsC76lA9EsOxsg7KfDEYaq7jjNV2NB2Gmm+RIbilr3i8 BQGIQRbWMwecP/aaWAaW =Pde1 -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--