From: John Keeping <john@keeping.me.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: Duy Nguyen <pclouds@gmail.com>,
Andreas Schwab <schwab@linux-m68k.org>,
Josef Wolf <jw@raven.inka.de>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: error: src refspec refs/heads/master matches more than one.
Date: Tue, 18 Feb 2014 19:35:20 +0000 [thread overview]
Message-ID: <20140218193520.GB1048@serenity.lan> (raw)
In-Reply-To: <xmqqha7wfdld.fsf@gitster.dls.corp.google.com>
On Tue, Feb 18, 2014 at 11:03:10AM -0800, Junio C Hamano wrote:
> Duy Nguyen <pclouds@gmail.com> writes:
>
> > Prevent is a strong word. I meant we only do it if they force
> > it. Something like this..
> >
> > -- 8< --
> > diff --git a/branch.c b/branch.c
> > index 723a36b..3f0540f 100644
> > --- a/branch.c
> > +++ b/branch.c
> > @@ -251,6 +251,11 @@ void create_branch(const char *head,
> > forcing = 1;
> > }
> >
> > + if (!force && dwim_ref(name, strlen(name), sha1, &real_ref))
> > + die(_("creating ref refs/heads/%s makes %s ambiguous.\n"
> > + "Use -f to create it anyway."),
> > + name, name);
>
> Does this check still allow you to create a branch "refs/heads/next"
> and then later create a branch "next"? The latter will introduce an
> ambiguity without any prevention, even though the prevention would
> trigger if the order in which these two branches are created is
> swapped--- the end result has ambiguity but the safety covers only
> one avenue to the confusing situation.
>
> And the only way I can think of to avoid that kind of confusion is
> to forbid creation of a subset of possible names by reserving a set
> of known (but arbitrary) prefixes---which I am not sure is a good
> way to go. At least not yet.
There's already the arbitrary set of prefixes in
refs.c::prettify_refname() and refs.c::ref_rev_parse_rules(). I can see
how a user might think that since "git log refs/heads/name" is
equivalent to "git log master" then "git branch refs/heads/name" should
be equivalent to "git branch name".
I don't think requiring "--force" for these branch names that overlap
with these special namespaces is a big leap from supporting them for
inspection commands. Although I'm not sure how sensible it is to
examine every remote name to catch something like "git branch
origin/master". Perhaps Duy's ambiguity check is the best thing for
that case.
next prev parent reply other threads:[~2014-02-18 19:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 11:31 error: src refspec refs/heads/master matches more than one Josef Wolf
2014-02-14 12:45 ` Andreas Schwab
2014-02-14 12:59 ` Duy Nguyen
2014-02-14 15:16 ` Josef Wolf
2014-02-14 15:35 ` David Kastrup
2014-02-14 16:52 ` Josef Wolf
2014-02-14 16:32 ` Junio C Hamano
2014-02-14 16:52 ` David Kastrup
2014-02-14 19:10 ` Junio C Hamano
2014-02-14 22:53 ` Josef Wolf
2014-02-15 8:53 ` Duy Nguyen
2014-02-17 14:25 ` Ingo Rohloff
2014-02-18 19:03 ` Junio C Hamano
2014-02-18 19:35 ` John Keeping [this message]
2014-02-18 19:51 ` Junio C Hamano
2014-02-18 20:01 ` John Keeping
2014-02-20 4:17 ` Michael Haggerty
2014-02-20 18:22 ` Junio C Hamano
2014-02-18 19:37 ` David Kastrup
2014-02-18 21:47 ` Junio C Hamano
2016-03-23 11:17 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218193520.GB1048@serenity.lan \
--to=john@keeping.me.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jw@raven.inka.de \
--cc=pclouds@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).