From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH 0/2] solaris test fixups
Date: Thu, 23 Jan 2014 15:54:04 -0500 [thread overview]
Message-ID: <20140123205404.GA12757@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqeh3yto8h.fsf@gitster.dls.corp.google.com>
On Thu, Jan 23, 2014 at 12:52:30PM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > and assume that it will fail. It doesn't. Solaris happily renames
> > some-file to a regular file named "no-such-dir". So we fail later during
> > the index-update, complaining about adding the entry "no-such-dir/", but
> > still exit(0) at the end. I'm mostly willing to just call Solaris crazy
> > for allowing the rename (Linux returns ENOTDIR), but I do wonder if
> > the index codepath could be improved (and especially to return an
> > error).
>
> I think j6t has a patch for that, a8933469 (mv: let 'git mv file
> no-such-dir/' error out on Windows, too, 2014-01-08).
Ah yeah, that looks like exactly the same issue (and the fix looks sane
from my cursory investigation). Thanks for the pointer. I wasn't
planning to look further into it, but now I can do so without feeling
guilty. :)
-Peff
prev parent reply other threads:[~2014-01-23 20:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 19:54 [PATCH 0/2] solaris test fixups Jeff King
2014-01-23 19:54 ` [PATCH 1/2] t7501: fix "empty commit" test with NO_PERL Jeff King
2014-01-23 19:55 ` [PATCH 2/2] t7700: do not use "touch -r" Jeff King
2014-01-23 21:12 ` Junio C Hamano
2014-01-23 21:14 ` Jeff King
2014-01-23 21:24 ` Junio C Hamano
2014-01-23 21:28 ` Jeff King
2014-01-23 20:52 ` [PATCH 0/2] solaris test fixups Junio C Hamano
2014-01-23 20:54 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123205404.GA12757@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).