From: Jonathan Nieder <jrnieder@gmail.com>
To: Samuel Bronson <naesten@gmail.com>
Cc: markus.heidelberg@web.de, Junio C Hamano <gitster@pobox.com>,
git <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] Makefile: add commented out 's for Emacs here, too
Date: Thu, 19 Dec 2013 15:52:21 -0800 [thread overview]
Message-ID: <20131219235221.GG20443@google.com> (raw)
In-Reply-To: <CAJYzjmcbQVgRk9pjyWSqaDPz6=kFQ9spE14Bq5aG4dnuo-t=oA@mail.gmail.com>
Hi,
Samuel Bronson wrote:
> Markus Heidelberg wrote:
>> In the buildroot project (it consists of Makefiles) there a lots of
>> those workarounds. There was a patch on the list to replace all
>> $(strip $(subst ",,$(FOO))) with $(call strip_dquotes, $(FOO)), but
>> $(call) is not allowed in git for compatibility reasons.
>
> Hmm. What compatibility reasons, and are they still applicable?
Good question.
$ git log -1 -S'$(call ' -- Makefile
commit 39c015c556f285106931e0500f301de462b0e46e
Author: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Date: Sat Feb 18 12:40:22 2006 +0100
Fixes for ancient versions of GNU make
Some versions of GNU make do not understand $(call), and have problems to
interpret rules like this:
some_target: CFLAGS += -Dsome=defs
[jc: simplified substitution a bit. ]
Signed-off-by: Johannes E. Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
A quick gmane search finds [1], which suggests the "make" where this
problem came up was on IRIX. I don't have a strong opinion either way
about whether such ancient 'make' is worth supporting (as a practical
matter, it's hard to keep testing and make sure such support still
works).
Would $(call) simplify the makefile much?
Thanks,
Jonathan
[1] http://thread.gmane.org/gmane.comp.version-control.git/16344
http://thread.gmane.org/gmane.comp.version-control.git/16345/focus=16375
http://thread.gmane.org/gmane.comp.version-control.git/48968/focus=49117
prev parent reply other threads:[~2013-12-19 23:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 22:07 [PATCH 1/3] Documentation/Makefile: add a commented-out ' to unconfuse Emacs Samuel Bronson
2009-05-25 22:07 ` [PATCH 2/3] Makefile: Add "make help" telling users to read INSTALL and Makefile Samuel Bronson
2009-05-25 22:07 ` [PATCH 3/3] Makefile: add commented out 's for Emacs here, too Samuel Bronson
2009-05-30 13:05 ` Markus Heidelberg
2009-05-30 18:37 ` Samuel Bronson
2009-05-30 19:07 ` Junio C Hamano
2009-05-30 22:01 ` Markus Heidelberg
2013-12-19 23:37 ` Samuel Bronson
2013-12-19 23:52 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219235221.GG20443@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=markus.heidelberg@web.de \
--cc=naesten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).