git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] pathspec: stop --*-pathspecs impact on internal parse_pathspec() uses
Date: Sat, 26 Oct 2013 02:39:12 -0400	[thread overview]
Message-ID: <20131026063912.GA24499@sigill.intra.peff.net> (raw)
In-Reply-To: <1382753360-32037-1-git-send-email-pclouds@gmail.com>

On Sat, Oct 26, 2013 at 09:09:20AM +0700, Nguyen Thai Ngoc Duy wrote:

>  Jeff, how about this?
>  
>  It's similar to your last suggestion (i.e.  relaxing the magic mask
>  about literal magic). In addition, it forces literal magic
>  unconditionally in this case, which I think is the right thing to do.
>  And it will fix other --*-pathspecs as well.

Yeah, I think I follow your reasoning. The problem I saw was just about
--literal-pathspec, but the real issue is that "blame" does not want
magic pathspecs at all, and your new flag turns that off.

So it fixes both my problem, as well as "git blame -- :(foo)bar".

-Peff

  reply	other threads:[~2013-10-26  6:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-25  3:49 [BUG] "git --literal-pathspecs blame" broken in master Jeff King
2013-10-25  4:04 ` Jeff King
2013-10-25  4:16   ` Duy Nguyen
2013-10-25  4:18     ` Jeff King
2013-10-25  4:11 ` Duy Nguyen
2013-10-26  2:09 ` [PATCH] pathspec: stop --*-pathspecs impact on internal parse_pathspec() uses Nguyễn Thái Ngọc Duy
2013-10-26  6:39   ` Jeff King [this message]
2013-10-26  2:09 ` Nguyễn Thái Ngọc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131026063912.GA24499@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).