git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC/PATCH] doc: git-foo was obsoleted several years ago
Date: Wed, 16 Oct 2013 21:18:07 -0400	[thread overview]
Message-ID: <20131017011807.GA14759@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq7gdc7v70.fsf@gitster.dls.corp.google.com>

On Wed, Oct 16, 2013 at 02:38:27PM -0700, Junio C Hamano wrote:

> >  Documentation/git-checkout.txt | 4 ++--
> [...]
> I recall that I wanted to see this change happen myself long time
> ago, and suspect that there may have been some reason that prevented
> us from doing so.  I might have found that AsciiDoc back then did
> not like the input if the headline name "git-checkout(1)" did not
> match the filename "git-checkout.txt" and the command in the NAME
> section "git-checkout", or links "linkgit:git-checkout[1]" from
> other pages couldn't have SP there, or something silly like that.

Yes, I think it is still broken. After applying Felipe's patch:

  $ cd Documentation
  $ make git-checkout.1
      GEN cmd-list.made
      SUBDIR ../
  make[1]: `GIT-VERSION-FILE' is up to date.
      ASCIIDOC git-checkout.xml
      XMLTO git-checkout.1

So far, so good...

  $ man -l git-checkout.1
  man: git-checkout.1: No such file or directory

Huh?

  $ ls git?checkout.1
  git_checkout.1

Oh.

There is similar asciidoc (actually, I think it is docbook) cleverness
with:

  $ make gitignore.1
      GEN cmd-list.made
      SUBDIR ../
      make[1]: `GIT-VERSION-FILE' is up to date.
      XMLTO gitignore.1

  $ ls gitignore.[0-9]
  gitignore.5

Now obviously what I asked for is wrong (we do not actually know how to
make gitignore.1), but I have certainly been confused by this in the
past when working on pages outside of section 1.

In both cases, it would be nice if we could tell xmlto "no, really, put
the output in this file". I'm not sure that is an option, though,
because in theory docbook output may be multiple files (the "-o" option
actually specifies an output directory).

Since we know our manpages are a much simpler case, we could probably
work around it by teaching the Makefile that building "git-foo.txt"
generates git_foo.1, and then moving that to git-foo.1.

-Peff

  reply	other threads:[~2013-10-17  1:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-21 11:37 [RFC/PATCH] doc: git-foo was obsoleted several years ago Felipe Contreras
2013-10-16 21:38 ` Junio C Hamano
2013-10-17  1:18   ` Jeff King [this message]
2013-10-17 11:13   ` Jakub Narębski
2013-10-17 12:06     ` Antoine Pelisse
2013-10-17 19:44     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131017011807.GA14759@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).