From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] symbolic-ref: trivial style fix
Date: Tue, 15 Oct 2013 16:16:28 -0700 [thread overview]
Message-ID: <20131015231628.GG9464@google.com> (raw)
In-Reply-To: <xmqq4n8ich89.fsf@gitster.dls.corp.google.com>
Junio C Hamano wrote:
> From: Felipe Contreras <felipe.contreras@gmail.com>
> Subject: C: have space around && and || operators
[...]
> builtin/read-tree.c | 2 +-
> builtin/rev-list.c | 2 +-
> builtin/symbolic-ref.c | 2 +-
> compat/regex/regcomp.c | 2 +-
> xdiff/xemit.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
For what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
[...]
> --- a/compat/regex/regcomp.c
> +++ b/compat/regex/regcomp.c
> @@ -339,7 +339,7 @@ re_compile_fastmap_iter (regex_t *bufp, const re_dfastate_t *init_state,
> p = buf;
> *p++ = dfa->nodes[node].opr.c;
> while (++node < dfa->nodes_len
> - && dfa->nodes[node].type == CHARACTER
> + && dfa->nodes[node].type == CHARACTER
It took a little staring to see what changed here. The preimage has
a tab, probably from an autoformatter gone wild. I don't think fixing
it should interfere with importing new versions of compat/regex, so
the change seems fine.
Thanks,
Jonathan
next prev parent reply other threads:[~2013-10-15 23:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 16:29 [PATCH] symbolic-ref: trivial style fix Felipe Contreras
2013-10-15 22:16 ` Junio C Hamano
2013-10-15 23:16 ` Jonathan Nieder [this message]
2013-10-15 23:34 ` Junio C Hamano
2013-10-16 3:33 ` Felipe Contreras
2013-10-16 21:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015231628.GG9464@google.com \
--to=jrnieder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).