From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Nicolas Pitre <nico@fluxnic.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: pack-object's try_delta fast path for v2 trees?
Date: Mon, 14 Oct 2013 20:54:17 -0400 [thread overview]
Message-ID: <20131015005417.GA16502@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8DgjCR+B+Bvbydns=bCZP5=TU1avPinnuDKqLZXS=4LNQ@mail.gmail.com>
On Tue, Oct 15, 2013 at 07:49:57AM +0700, Nguyen Thai Ngoc Duy wrote:
> I see this as pack-objects peformance improvements only. If we could
> make pack-objects run like 10% faster (even only with -adf), then it
> may be worth trying. The 10% is a total guess though as I haven't
> checked how much time we spend in searching deltas.
For "repack -ad", generally we don't spend that much time on deltas. It
depends what your pre-repack state is, of course, but I find that most
of the time goes to "counting objects". With "-adf", I would guess that
we easily spend something like 95% of the time on compressing for a
large repository (just try "repack -adf" on the kernel; even with 8
cores it's a half hour or more on my machine, versus about 25 seconds to
count the objects).
So I think you could potentially get a lot of speedup for the "-adf"
case (and likewise "git gc --aggressive").
-Peff
next prev parent reply other threads:[~2013-10-15 0:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 3:42 pack-object's try_delta fast path for v2 trees? Duy Nguyen
2013-10-12 14:52 ` Nicolas Pitre
2013-10-15 0:19 ` Jeff King
2013-10-15 0:49 ` Duy Nguyen
2013-10-15 0:54 ` Jeff King [this message]
2013-10-15 1:45 ` Nicolas Pitre
2013-10-15 1:51 ` Jeff King
2013-10-15 2:13 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015005417.GA16502@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).