From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] split_ident: parse timestamp from end of line
Date: Mon, 14 Oct 2013 18:31:37 -0400 [thread overview]
Message-ID: <20131014223137.GA12744@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqwqlfebhi.fsf@gitster.dls.corp.google.com>
On Mon, Oct 14, 2013 at 03:25:29PM -0700, Junio C Hamano wrote:
> > + /*
> > + * Look from the end-of-line to find the trailing ">" of the mail
> > + * address, even though we should already know it as split->mail_end.
> > + * This can help in cases of broken idents with an extra ">" somewhere
> > + * in the email address. Note that we are assuming the timestamp will
> > + * never have a ">" in it.
> > + *
> > + * Note also that this memchr can never return NULL, as we would
> > + * always find at least the split->mail_end closing bracket.
> > + */
> > + cp = memrchr(split->mail_end, '>', len - (split->mail_end - line));
> > + for (cp = cp + 1; cp < line + len && isspace(*cp); cp++)
> > ;
>
> "git grep" tells me this is the first use of memrchr(), which,
> unlike memchr(), is _GNU_SOURCE-only if I am not mistaken, so we may
> need a fallback definition in the compat/ and NEEDS_MEMRCHR in the
> Makefile, I think.
Yeah, you are right[1]. I'm happy to re-roll. I wonder if we even need
to worry about a compatibility wrapper. We are already doing pointer
manipulations, and it is probably just as readable to roll the loop by
hand.
-Peff
[1] I even looked at "man memrchr" on my glibc system and was surprised
to see it mentioned above the "#define _GNU_SOURCE" fold. But that
"fold" is used only sometimes (e.g., strchrnul), and not others (in
memrchr, the portability bits are listed at the end of the
synopsis). Grr.
next prev parent reply other threads:[~2013-10-14 22:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 20:27 [PATCH] split_ident: parse timestamp from end of line Jeff King
2013-10-14 22:25 ` Junio C Hamano
2013-10-14 22:31 ` Jeff King [this message]
2013-10-14 22:45 ` Jeff King
2013-10-14 22:45 ` Junio C Hamano
2013-10-14 23:29 ` Jeff King
2013-10-15 17:52 ` Junio C Hamano
2013-10-15 18:03 ` Jeff King
2013-10-15 18:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014223137.GA12744@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).