git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Antoine Pelisse <apelisse@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: Git tag output order is incorrect (IMHO)
Date: Sun, 8 Sep 2013 04:03:11 -0400	[thread overview]
Message-ID: <20130908080311.GA25498@sigill.intra.peff.net> (raw)
In-Reply-To: <CALWbr2w7XCuD5tUSwR+Cwv4wyXLk8MHDGyU2Dr+jA9vOfDYqig@mail.gmail.com>

On Tue, Aug 20, 2013 at 05:12:47PM +0200, Antoine Pelisse wrote:

> On Sat, Jul 20, 2013 at 2:22 AM, Jeff King <peff@peff.net> wrote:
> > I do plan to finish it eventually, but if anyone else feels like picking
> > it up, I'd be glad to review patches and/or share my work-in-progress as
> > a starting point.
> 
> I have some free time to come, and would like to work on that feature.
> Does the offer still hold ?
> If it does, I would be interested in your patches.

I'm sorry I have taken so long to get back to you on this. I was hoping
to revisit the topic and make sure the patches were in a sensible state
for showing to somebody. But it took me some time to get around to it,
and now that I have, they're really not looking very good.

My general strategy was to factor out all of the "which refs to select"
code from git-tag (which knows --contains and --points-at) and
git-branch (which knows --merged, --no-merged, and --contains), and then
make them all available in a library-ish way to both commands, as well
as for-each-ref (which also knows name matching, which all 3 should
know, too). You can see my messy in-progress commit (that does not even
compile) at:

  git://github.com/peff/git.git jk/contains-wip

Part of the complication is that the filters have to happen at different
times (you can efficiently ask "--contains" for each ref as you see it,
but asking "--merged" must happen after you have collected each one).

I do not recall at this point what other issues led me to stop working
on it (it may simply have been time for dinner, and I never came back to
it). So the patches there may or may not actually be helpful to you.

Sorry I can't be more helpful. I'd be happy to discuss or review if you
want to work on it.

-Peff

  reply	other threads:[~2013-09-08  8:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-18 15:27 Git tag output order is incorrect (IMHO) Rahul Bansal
2013-07-18 15:51 ` Duy Nguyen
2013-07-18 15:56   ` Duy Nguyen
2013-07-18 15:58     ` Rahul Bansal
2013-07-18 15:57   ` Rahul Bansal
2013-07-18 16:14     ` Duy Nguyen
2013-07-18 17:42 ` Andreas Schwab
2013-07-19 19:40   ` Junio C Hamano
2013-07-20  0:22     ` Jeff King
2013-08-20 15:12       ` Antoine Pelisse
2013-09-08  8:03         ` Jeff King [this message]
2013-10-16 17:56           ` Jeff King
2013-10-16 18:06             ` Antoine Pelisse
2013-09-08 22:49 ` Felipe Contreras
2013-09-11 13:42   ` Phil Hord
2013-09-11 17:54     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130908080311.GA25498@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=apelisse@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).