From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, judge.packham@gmail.com, iveqy@iveqy.com,
Jorge-Juan.Garcia-Garcia@ensimag.imag.fr, gitster@pobox.com
Subject: Re: [PATCH 2/2] submodule: don't print status output with ignore=all
Date: Sat, 10 Aug 2013 16:37:09 +0000 [thread overview]
Message-ID: <20130810163709.GD164436@vauxhall.crustytoothpaste.net> (raw)
In-Reply-To: <51FE9C49.4020902@web.de>
[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]
On Sun, Aug 04, 2013 at 08:24:09PM +0200, Jens Lehmann wrote:
> I'm a bit confused. The commit message talks about "git status", but the code
> you changed handles "git submodule summary". Looks like you are trying to fix
> the output of status when the status.submodulesummary option is set, right?
> That's a good thing to do.
>
> But your patch also changes the default behavior of "git submodule summary",
> which is a change in behavior as that is currently not configurable via the
> ignore option (and I believe it should stay that way for backward compatibility
> reasons unless actual users provide sound reasons to change that). So a NACK
> on this patch from me (and a note to self that tests are missing that should
> have failed due to this change).
Right, that wasn't the intent.
> As a short term solution you could honor the submodule.<name>.ignore setting
> only if --for-status is used, as that is explicitly given by "git status" when
> it forks the "git submodule summary" script (to make it prepend "# " to each
> line, which it could do easily itself nowadays using recently added code ;-).
I think I'm going to go this route. My goal is to fix up the TODO tests
and make them work so I can get more familiar with the code.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-10 16:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 17:14 Don't print status output with submodule.<name>.ignore=all brian m. carlson
2013-08-03 17:14 ` [PATCH 1/2] submodule: fix confusing variable name brian m. carlson
2013-08-03 18:14 ` Jonathan Nieder
2013-08-04 17:34 ` Jens Lehmann
2013-08-04 21:29 ` Fredrik Gustafsson
2013-08-06 17:33 ` Jens Lehmann
2013-08-08 17:44 ` Ramsay Jones
2013-08-09 17:26 ` Fredrik Gustafsson
2013-08-09 18:53 ` Junio C Hamano
2013-08-11 19:53 ` Mark Levedahl
2013-08-03 17:14 ` [PATCH 2/2] submodule: don't print status output with ignore=all brian m. carlson
2013-08-03 18:24 ` Jonathan Nieder
2013-08-04 18:24 ` Jens Lehmann
2013-08-10 16:37 ` brian m. carlson [this message]
2013-08-11 16:03 ` brian m. carlson
2013-08-11 18:33 ` Jonathan Nieder
2013-08-17 16:27 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130810163709.GD164436@vauxhall.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=Jens.Lehmann@web.de \
--cc=Jorge-Juan.Garcia-Garcia@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=iveqy@iveqy.com \
--cc=jrnieder@gmail.com \
--cc=judge.packham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).