From: Pete Wyckoff <pw@padd.com>
To: kazuki saitoh <ksaitoh560@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-p4: use "p4 fstat" to interpret View setting
Date: Fri, 2 Aug 2013 17:53:59 -0400 [thread overview]
Message-ID: <20130802215359.GB9142@padd.com> (raw)
In-Reply-To: <CACGba4yGZDnr-1R-6k-sZoh4P=fu9M0bsmH3uoqj3tXUPsZRYw@mail.gmail.com>
ksaitoh560@gmail.com wrote on Fri, 02 Aug 2013 17:02 +0900:
> I trying clone Perforce project and I found git-p4. It's a great tool!
>
> And I don't know how to exclude special extension file in a directory?
> (Practically, I want to exclude Excel files at git p4 clone/sync.)
>
> In Perforce, View setting of p4 client can describe
> -//depot/project/files/*.xls //client/project/files/*.xls
> to exclude Excel files.
> But "git p4 --use-client-spec" cannot support '*'.
>
> In git-p4.py, "map_in_client" method analyzes View setting and return
> client file path.
> So I modify the method to just use p4 command, "p4 fstat -T clientFile".
>
> I'd like to know your opinions about that and what you think about the
> suggestion.
This is either incredibly brilliant or fundamentally broken. I'm
hoping for the former. :)
Your theory is: there is a client spec, and p4 knows how to
interpret these things, so instead of figuring out and
implementing the algorithms for %% and * and ... in git-p4, just
ask p4 directly.
Let me play with this for a bit. I wonder about the performance
aspects of doing a "p4 fstat" for every file. Would it be
possible to do one or a few batch queries higher up somewhere?
A few nit-picky questions below, just on the test bits, while I
play with your code.
> diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
> index 2098b9b..fbda1ad 100644
> --- a/t/lib-git-p4.sh
> +++ b/t/lib-git-p4.sh
> @@ -48,6 +48,9 @@ P4DPORT=$((10669 + ($testid - $git_p4_test_start)))
> P4PORT=localhost:$P4DPORT
> P4CLIENT=client
> P4EDITOR=:
> +P4USER=""
> +P4PASS=""
> +P4CHARSET=""
Why do you need these?
> diff --git a/t/t9801-git-p4-branch.sh b/t/t9801-git-p4-branch.sh
> index 2bf142d..b97bdda 100755
> --- a/t/t9801-git-p4-branch.sh
> +++ b/t/t9801-git-p4-branch.sh
> @@ -480,6 +480,7 @@ test_expect_success 'use-client-spec detect-branches
> skips branches setup' '
> test_expect_success 'use-client-spec detect-branches skips branches' '
> client_view "//depot/usecs/... //client/..." \
> "-//depot/usecs/b3/... //client/b3/..." &&
> + ( p4 sync ) &&
> test_when_finished cleanup_git &&
How does the p4 sync help here?
> +test_expect_success 'view wildcard *' '
> + client_view "//depot/... //client/..." \
> + "-//depot/dir1/*.junk //client/dir1/*.junk" \
> + "-//depot/dir2/*.junk //client/dir2/*.junk" &&
> + (p4 sync ) &&
> + files="dir1/file11 dir1/file12 dir2/file21 dir2/file22" &&
> + client_verify $files &&
> + git p4 clone --use-client-spec --dest="$git" //depot &&
> + git_verify $files
> +'
It works! Cool.
-- Pete
next parent reply other threads:[~2013-08-02 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACGba4yGZDnr-1R-6k-sZoh4P=fu9M0bsmH3uoqj3tXUPsZRYw@mail.gmail.com>
2013-08-02 21:53 ` Pete Wyckoff [this message]
2013-08-05 4:49 ` [PATCH] git-p4: use "p4 fstat" to interpret View setting kazuki saitoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802215359.GB9142@padd.com \
--to=pw@padd.com \
--cc=git@vger.kernel.org \
--cc=ksaitoh560@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).