From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Beller <stefanbeller@googlemail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtins: search builtin commands via binary search.
Date: Fri, 26 Jul 2013 13:57:37 -0700 [thread overview]
Message-ID: <20130726205737.GI14690@google.com> (raw)
In-Reply-To: <1374871850-24323-1-git-send-email-stefanbeller@googlemail.com>
Hi,
Stefan Beller wrote:
> --- a/git.c
> +++ b/git.c
> @@ -309,9 +309,18 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
> return 0;
> }
>
> +static int compare_internal_command(const void *a, const void *b) {
> + /* The first parameter is of type char* describing the name,
> + the second is a struct cmd_struct */
Style:
/*
* Multi-line comments in git look like this, with an initial
* "/*" line, a leading "*" on each line with text, and a line
* with '*' '/' at the end.
*/
[...]
> @@ -447,12 +456,12 @@ static void handle_internal_command(int argc, const char **argv)
> argv[0] = cmd = "help";
> }
>
> - for (i = 0; i < ARRAY_SIZE(commands); i++) {
> - struct cmd_struct *p = commands+i;
> - if (strcmp(p->cmd, cmd))
> - continue;
> + struct cmd_struct *p = (struct cmd_struct *)bsearch(cmd, commands,
> + ARRAY_SIZE(commands), sizeof(struct cmd_struct),
> + compare_internal_command);
No need to cast --- this is C.
Fun. Does this result in a measurable speedup, or is it just for more
pleasant reading?
Thanks and hope that helps,
Jonathan
next prev parent reply other threads:[~2013-07-26 20:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 20:50 [PATCH] builtins: search builtin commands via binary search Stefan Beller
2013-07-26 20:57 ` Jonathan Nieder [this message]
2013-07-27 8:49 ` Stefan Beller
2013-07-27 8:50 ` Stefan Beller
2013-07-27 9:13 ` Andreas Schwab
2013-07-28 9:05 ` Eric Sunshine
2013-07-29 16:18 ` Junio C Hamano
2013-07-27 0:26 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726205737.GI14690@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=stefanbeller@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).