From: Jeff King <firstname.lastname@example.org> To: Junio C Hamano <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [PATCH 4/4] describe/name-rev: tell name-rev to peel the incoming object to commit first Date: Tue, 9 Jul 2013 01:35:33 -0400 [thread overview] Message-ID: <20130709053533.GA4395@sigill.intra.peff.net> (raw) In-Reply-To: <email@example.com> On Mon, Jul 08, 2013 at 10:33:26PM -0700, Junio C Hamano wrote: > Jeff King <firstname.lastname@example.org> writes: > > > 1. Behave more or less the same between "git name-rev $sha1" and "echo > > $sha1 | git name-rev --stdin". Your patch improves that. Though I > > note that --peel-to-commit does not affect --stdin at all. Should > > it? And of course the two differ in that the command line will take > > any rev-parse expression, and --stdin only looks for full sha1s. > > To "Should it?", I do not deeply care. "--peel-to-commit" is an > exception that only is needed to support "describe". > > I could instead have tucked "^0" at the end of each argument when > "describe" calls out to "name-rev" without adding this new option, > which is much much closer to what is really going on. Yeah, I tend to think that is a more sane interface, even though it is a little more work in git-describe. Although I am still not clear on why it would not be up to the caller of git-describe in the first place to decide which they wanted. -Peff
next prev parent reply other threads:[~2013-07-09 5:35 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-07 22:33 [PATCH 0/4] Make "git name-rev $(git rev-parse v1.8.3)" work Junio C Hamano 2013-07-07 22:33 ` [PATCH 1/4] name-ref: factor out name shortening logic from name_ref() Junio C Hamano 2013-07-08 8:52 ` Michael Haggerty 2013-07-08 15:04 ` Junio C Hamano 2013-07-07 22:33 ` [PATCH 2/4] name-rev: allow converting the exact object name at the tip of a ref Junio C Hamano 2013-07-08 12:20 ` Ramkumar Ramachandra 2013-07-08 15:12 ` Junio C Hamano 2013-07-07 22:33 ` [PATCH 3/4] describe: use argv-array Junio C Hamano 2013-07-09 4:51 ` Jeff King 2013-07-09 14:55 ` Junio C Hamano 2013-07-09 16:00 ` Junio C Hamano 2013-07-09 18:53 ` Jeff King 2013-07-07 22:33 ` [PATCH 4/4] describe/name-rev: tell name-rev to peel the incoming object to commit first Junio C Hamano 2013-07-08 13:08 ` Ramkumar Ramachandra 2013-07-09 5:12 ` Jeff King 2013-07-09 5:06 ` Jeff King 2013-07-09 5:33 ` Junio C Hamano 2013-07-09 5:35 ` Jeff King [this message] 2013-07-09 11:45 ` Junio C Hamano 2013-07-09 12:42 ` Ramkumar Ramachandra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130709053533.GA4395@sigill.intra.peff.net \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 4/4] describe/name-rev: tell name-rev to peel the incoming object to commit first' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).