From: Jeff King <email@example.com> To: Ramkumar Ramachandra <firstname.lastname@example.org> Cc: Junio C Hamano <email@example.com>, firstname.lastname@example.org Subject: Re: [PATCH 4/4] describe/name-rev: tell name-rev to peel the incoming object to commit first Date: Tue, 9 Jul 2013 01:12:52 -0400 [thread overview] Message-ID: <20130709051252.GG27903@sigill.intra.peff.net> (raw) In-Reply-To: <CALkWK0nMmQO=cML-s9rgku+_4fZnYwtGC+daYPOBPn6-RFZjemail@example.com> On Mon, Jul 08, 2013 at 06:38:32PM +0530, Ramkumar Ramachandra wrote: > Junio C Hamano wrote: > > With this on top of the other patches in this series, you would get: > > > > $ git describe --contains $(git rev-parse v1.8.3 v1.8.3^0) > > v1.8.3 > > v1.8.3 > > > > while you can still differentiate tags and the commits they point at > > with: > > > > $ git name-rev --refs=tags/\* --name-only $(git rev-parse v1.8.3 v1.8.3^0) > > v1.8.3 > > v1.8.3^0 > > > > The difference in these two behaviours is achieved by adding --peel-to-commit > > option to "name-rev" and using it when "describe" internally calls it. > > Essentially a revert of [2/4] for describe-purposes, achieved by > adding an ugly command-line option to name-rev. I don't think it is a revert. The two patches complement each other. 2/4 is basically "if we have a non-commit object which is pointed at directly by a tip, make sure we name it by that tip". But you can only get such an object by "name-rev --stdin", since name-rev peels its command-line arguments. 4/4 is "stop peeling command line objects, so we can find their exact tips". IOW, it lets the command line do the same thing that --stdin was able to do in 2/4. > Before we argue any further, let me ask: who uses name-rev (and > depends strongly on its output)?! Our very own testsuite does not > exercise it. There are exactly two users of describe/name-rev: > > 1. prompt, obviously. > 2. DAG-tests, for simplification. Yeah, I'm not clear on who we are breaking with the change in default peeling behavior, nor why the "describe --contains" wrapper wants to keep it. -Peff
next prev parent reply other threads:[~2013-07-09 5:13 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-07 22:33 [PATCH 0/4] Make "git name-rev $(git rev-parse v1.8.3)" work Junio C Hamano 2013-07-07 22:33 ` [PATCH 1/4] name-ref: factor out name shortening logic from name_ref() Junio C Hamano 2013-07-08 8:52 ` Michael Haggerty 2013-07-08 15:04 ` Junio C Hamano 2013-07-07 22:33 ` [PATCH 2/4] name-rev: allow converting the exact object name at the tip of a ref Junio C Hamano 2013-07-08 12:20 ` Ramkumar Ramachandra 2013-07-08 15:12 ` Junio C Hamano 2013-07-07 22:33 ` [PATCH 3/4] describe: use argv-array Junio C Hamano 2013-07-09 4:51 ` Jeff King 2013-07-09 14:55 ` Junio C Hamano 2013-07-09 16:00 ` Junio C Hamano 2013-07-09 18:53 ` Jeff King 2013-07-07 22:33 ` [PATCH 4/4] describe/name-rev: tell name-rev to peel the incoming object to commit first Junio C Hamano 2013-07-08 13:08 ` Ramkumar Ramachandra 2013-07-09 5:12 ` Jeff King [this message] 2013-07-09 5:06 ` Jeff King 2013-07-09 5:33 ` Junio C Hamano 2013-07-09 5:35 ` Jeff King 2013-07-09 11:45 ` Junio C Hamano 2013-07-09 12:42 ` Ramkumar Ramachandra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130709051252.GG27903@sigill.intra.peff.net \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 4/4] describe/name-rev: tell name-rev to peel the incoming object to commit first' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).