From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] cache.h: move remote/connect API out of it
Date: Tue, 9 Jul 2013 00:21:06 -0400 [thread overview]
Message-ID: <20130709042106.GC27903@sigill.intra.peff.net> (raw)
In-Reply-To: <7v1u78zrko.fsf@alter.siamese.dyndns.org>
On Mon, Jul 08, 2013 at 02:09:59PM -0700, Junio C Hamano wrote:
> The definition of "struct ref" in "cache.h", a header file so
> central to the system, always confused me. This structure is not
> about the local ref used by sha1-name API to name local objects.
> [...]
> * I hate to to this kind of code-movement in the middle of the
> cycle, but every time I follow the push->transport codepath, I
> become disoriented by these "struct ref"s.
FWIW, this has often bugged me, too. I did not check what fallouts this
will have for series in flight, but in general, I think it is a good
thing to be doing.
-Peff
next prev parent reply other threads:[~2013-07-09 4:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 21:09 [PATCH] cache.h: move remote/connect API out of it Junio C Hamano
2013-07-08 21:35 ` Junio C Hamano
2013-07-09 4:21 ` Jeff King [this message]
2013-07-09 5:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709042106.GC27903@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).